Apply Rebel Branding to Android platform#48
Merged
Conversation
DanielaOrtner
approved these changes
Mar 25, 2024
Contributor
DanielaOrtner
left a comment
DanielaOrtner
left a comment
There was a problem hiding this comment.
Thank you for making our code base consistent. :)
madmiraal
added
PR Type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #16. It addresses some of the external rebranding missed in #16, for example the default launcher icon used by applications. However, this PR is more about the class and filename branding of the Android platform.
In addition, while renaming various classes, it uses the opportunity to apply some consistency to the naming structure: All classes that access the Android Java Native interface have been renamed
AndroidJNI*, and the files toandroid_jni_*. More work needs to be done, but this PR should provide some much needed consistency.