Change Android ndk_platform option to android_ndk_api#57
Merged
DanielaOrtner merged 1 commit intoMay 15, 2024
Conversation
- Uses an integer for the Android NDK API target instead of "android-<api>". - Removes the ignored ANDROID_SDK_ROOT SCons option. - Includes a general clean up of android/detect.py.
DanielaOrtner
approved these changes
May 15, 2024
Contributor
DanielaOrtner
left a comment
DanielaOrtner
left a comment
There was a problem hiding this comment.
Good work. This change makes it so much clearer.
madmiraal
added
PR Type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Android build has an
ndk_platformoption to specify the minimum Android API that the build should support. Not only is the option name confusing (it affects the Android API not the NDK platform) it requires the inclusion of the word "android" in the value.This PR changes the name of the option to the more descriptive
android_ndk_api, it also uses an integer for the minimum API level supported.In addition, this PR also removes the ignored
ANDROID_SDK_ROOTSCons option and includes a general clean up ofandroid/detect.py.