Update create release to support updated Android builds#59
Merged
Conversation
DanielaOrtner
approved these changes
May 16, 2024
Contributor
DanielaOrtner
left a comment
DanielaOrtner
left a comment
There was a problem hiding this comment.
Thank you for being continuously one step ahead and keeping the nightly build running smoothly. :)
madmiraal
added
PR Type: Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#55 upgraded the build tools used to create the Rebel Android templates, which included a requirement to upgrade Java to version 17. The servers used to create a Rebel release (including the Rebel's nightly release) currently use Java 11 as the default. This PR updates the create release workflow to change the version of Java used to 17. Similarly, it ensures that the
libc++shared libraries are the ones that match the version of the NDK used (23.2.8568313). Both options have been set up as variables; so they can be more easily updated in future.Finally, this PR also removes the installation of SCons when creating the templates; as #55 (f9586ee) has removed this requirement.