fix: add Phractal eval verification metadata#106
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f88fbdf53e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if config_path is None: | ||
| return None | ||
|
|
||
| parser = configparser.ConfigParser() |
There was a problem hiding this comment.
Using configparser.ConfigParser() with default interpolation makes parser.get(..., "url") raise InterpolationSyntaxError for valid remotes containing % escapes (for example, URL-encoded paths like %20). In that scenario infer_verify_command() can now throw instead of falling back to normal verifier inference, causing startup/verification inference failures on affected repos. Use interpolation=None (or RawConfigParser) and/or catch configparser.Error around the get() call.
Useful? React with 👍 / 👎.
| --- | ||
| status: pending | ||
|
|
||
| ## status: done |
There was a problem hiding this comment.
The task frontmatter is malformed (## status: done) and no closing --- delimiter is present, so queue tooling will treat 0099.md as invalid metadata rather than a cleanly completed task. This prevents normal archival logic (which looks for ^status: done) and keeps the queue/reporting in an inconsistent state. Replace the heading-like key with valid YAML (status: done) and close the frontmatter block.
Useful? React with 👍 / 👎.
…le tasks Pentest findings (both confirmed by source inspection): - #142 (urgent): $after_task shell injection in run_evaluation() — agent- controlled text interpolated into Python -c string; fix via env var - #143 (urgent): PR title injected raw into builder and pentest prompts — sanitize or wrap in XML data label before injection Closed: - #77 (wontfix): code-reviewer.md no longer exists; system unified into review.md in PR #107; the described issue is absent from the codebase - #129 (wontfix/superseded): absorbed into #106 (lower-numbered, picked first); #106 updated to include the 50-task hard cap explicitly Queue: 53 pending (same count; +2 urgent, -2 wontfix)
1 participant
Summary
Test plan