Conversation
|
Note: Generated by Claude Code |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a66d23e5e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Python | ||
| "app/models", | ||
| "app/auth", | ||
| "app/api", |
There was a problem hiding this comment.
The new entries add duplicates of existing candidates (for example app/api is already present earlier in the same list), which causes high_signal_focus_paths() to emit repeated hints instead of distinct areas to explore. In repos where only a duplicated path exists, the focus list can become ['app/api', 'app/api'] (and similarly for src/api), reducing prompt quality and path diversity for each cycle.
Useful? React with 👍 / 👎.
- Simplify high_signal_focus_paths() by removing redundant fallback (#16) - Broaden _extract_shell_command regex to handle bash/sh/dash wrappers (#17) - Add docstring to expected_cycle_commits() documenting commit contract (#18) - Add Python/Go/Rust paths to HIGH_SIGNAL_PATH_CANDIDATES (#19) https://claude.ai/code/session_011hjFhGSxRM4pWsWN1r4GSM
fazxes
force-pushed
the
claude/review-pr13-fpEy7
branch
from
a66d23e to
58512da
Compare
nightshift plan "feature" --agent claude now invokes the agent to generate a feature plan, parses the output, and displays formatted markdown with scope warnings. Adds plan_command_for_agent() and run_plan_agent() to planner.py with PLAN_AGENT_MAX_TURNS (10) and PLAN_AGENT_TIMEOUT (300s). 13 new tests, 509 total passing. Completes task #20.
2 participants
Summary
Quality improvements identified during code review of PR #13 ("Harden Nightshift from live validation runs").
high_signal_focus_paths()by removing redundant filesystem fallback (fixes Remove redundant fallback in high_signal_focus_paths() #16)_extract_shell_commandregex to handlebash -c,sh -c,dash -cwrappers in addition to-lc(fixes _extract_shell_command regex only matches -lc quoted style #17)expected_cycle_commits()documenting the one-fix-one-commit contract (fixes Document the one-fix-one-commit contract for expected_cycle_commits() #18)HIGH_SIGNAL_PATH_CANDIDATESfor multi-language support (fixes HIGH_SIGNAL_PATH_CANDIDATES is JS/TS-centric #19)Test plan
high_signal_focus_pathsstill pass with simplified logicbash -candsh -cshell wrapper detection passmake checkpasses (ruff, mypy, pytest)__all__sort order in__init__.pymay need updating for ruff RUF022https://claude.ai/code/session_011hjFhGSxRM4pWsWN1r4GSM