fix: add trailing anchors to all status: regex patterns in signals.py#207
Merged
fix: add trailing anchors to all status: regex patterns in signals.py#207
Conversation
All four unanchored `^status:\s*pending` patterns now use `^status:\s*pending\s*$` to prevent false matches on values like `status: pending-review`. Also tightens `^priority:\s*urgent` to `^priority:\s*urgent\s*$` for consistency. Addresses task #216 and the meta-reviewer advisory note from PR #205.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^status:\s*pendingpatterns in.recursive/engine/signals.pynow use^status:\s*pending\s*$to prevent false matches on values likestatus: pending-review^priority:\s*urgentinhas_urgent_tasksalso tightened to^priority:\s*urgent\s*$for consistencyPatterns fixed
count_pending_tasks^status:\s*pending^status:\s*pending\s*$count_stale_tasks^status:\s*pending^status:\s*pending\s*$count_pending_pentest_framework_tasks^status:\s*pending^status:\s*pending\s*$has_urgent_tasks^status:\s*pending+^priority:\s*urgent\s*$Test plan
make checkpasses (all 926 tests pass, ruff/mypy clean)status: pending-reviewvaluessource:andtarget:patterns in the same file