fix: remove dead code in signals.py and unused constant in test_signals.py#245
Merged
fix: remove dead code in signals.py and unused constant in test_signals.py#245
Conversation
…ls.py - Move datetime imports to module level (was deferred inside try blocks) - Remove unreachable eval_date fallback in sessions_since_eval (eval_ts is always non-empty from strftime, so the else branch was dead) - Remove unused _VALID_EVAL_CONTENT constant from test_signals.py Closes task #245.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetimeimports to module level in.recursive/engine/signals.py(was deferred insidetryblocks and function bodies, inconsistently)eval_datefallback insessions_since_eval:eval_tsis always a non-empty string (fromstrftime) when control reaches the comparison, so theif eval_ts else eval_datebranch was dead_VALID_EVAL_CONTENTmodule-level constant from.recursive/tests/test_signals.py(the_make_eval()helper already builds equivalent content inline)Closes task #245. Identified in PR #244 code review.
Test plan
make checkpasses (1156 tests, ruff, mypy, format all green)sessions_since_evalbehaviour unchanged -- only the dead fallback path removed