Skip to content

docs: add follow-up tasks from PR #41 code review#44

Merged
fazxes merged 1 commit intomainfrom
docs/review-followup-tasks
Apr 5, 2026
Merged

docs: add follow-up tasks from PR #41 code review#44
fazxes merged 1 commit intomainfrom
docs/review-followup-tasks

Conversation

@fazxes
Copy link
Copy Markdown
Member

@fazxes fazxes commented Apr 5, 2026

Summary

Both flagged as advisory notes during PR #41 code review. Per project rule: review notes MUST become tasks.

Test plan

  • Docs-only change (task files), no code modifications

Task #40: assert AGENT_DEFAULT_MODELS matches DEFAULT_CONFIG
Task #41: assert cache_read pricing for gpt-5.4-mini/nano
@fazxes fazxes merged commit c8fcf8f into main Apr 5, 2026
2 checks passed
@fazxes fazxes deleted the docs/review-followup-tasks branch April 5, 2026 03:17
fazxes added a commit that referenced this pull request Apr 5, 2026
… to #42

Task #40 was accidentally overwritten by PR #44. Restored original
CONTRIBUTING.md task content and moved the AGENT_DEFAULT_MODELS sync
test task to #42.
fazxes added a commit that referenced this pull request Apr 5, 2026
- Fix shell injection in compact_handoffs(): pass path via env var
  instead of interpolating into Python -c string
- Move datetime import to module top level in compact.py
- Add compact.py to OPERATIONS.md module table
- Create follow-up tasks #43 (TypedDict for _parse_handoff) and
  #44 (fix same injection pattern in cleanup functions)
fazxes added a commit that referenced this pull request Apr 5, 2026
Upstream had task #43 (CONTRIBUTING.md). Renumber:
- #43: CONTRIBUTING.md (from upstream)
- #44: ParsedHandoff TypedDict (review follow-up)
- #45: Shell injection fix in cleanup functions (review follow-up)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant