Conversation
…stamps When PlayEngine pushes a buffered keyframe (or any prelude event) captured before the live anchor (videoBaseTs / audioBaseTs / publisher timestamp offset), the rebase formula eventTime - baseTs + 2 produces a negative result. The negative int writes to the wire as the equivalent unsigned-32 value, which RTMP clients render as a far-future timestamp (e.g. -97 ms -> 0xFFFFFF9F -> ~24.85 days when bit 31 is stripped, or ~49.7 days when read as full unsigned-32). Clamp negative adjusted timestamps to 1 so buffered events precede the first live frame at ts=2 without leaking into the unsigned-32 upper half. Verified via ffplay end-to-end against an SRT/TS publisher: video start went from 2147483.551s to 0.001s.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
This PR fixes #Enter issue number
Changes proposed in this pull request: