Feat issue 33604 callable key prefix #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
…-callable_key_prefix
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
RedBeardCode
force-pushed
the
feat-issue-33604-callable_key_prefix
branch
3 times, most recently
from
512cbd3 to
646d30d
Compare
Based on the great work of https://github.com/sailoboats I try to make my first pull request. The origin PR django#15553 seems to be abandoned. So I tried implement the things mentioned in the comment. I hope I didn't missed something.
RedBeardCode
force-pushed
the
feat-issue-33604-callable_key_prefix
branch
from
646d30d to
4fc24cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-33604
Branch description
Based on the great work of @alexei I try to make my first pull request. The origin PR django#15553 seems to be abandoned. So I tried implement the things mentioned in the comment. I hope I didn't missed something.
This update allows to set the key_prefix as a callable.
Discussions:
https://code.djangoproject.com/ticket/33604
https://groups.google.com/g/django-developers/c/UbD1DkV1uPo
Checklist
mainbranch.