chore: refactor advisory systems table#1175
Conversation
|
It looks good, I ran the tests and they are passing. Do we need to update anything in them? |
|
Nope, the PR is ready to be reviewed and merged if everything is fine |
|
You were right, somehow I did not push the commit for tests rewrite |
mkholjuraev
force-pushed
the
refactor-advisor-systems
branch
from
0d6f87d to
07d32bf
Compare
|
@Fewwy I completely forgot about this PR. Would you mind having another look? |
gkarat
left a comment
gkarat
left a comment
There was a problem hiding this comment.
Hey, everything works well. Though, I have noticed an increase in network requests number (mostly, /system_profile/... and /tags requests). Can you please take a look and tell if it is expected? If not, can we make sure the performance doesn't downgrade after the PR changes?
Before:
After:
gkarat
left a comment
gkarat
left a comment
There was a problem hiding this comment.
No longer reproducible ^, I think it was not caused by your PR. Let's have it merged, thanks @mkholjuraev
|
🎉 This PR is included in version 1.67.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 participants
Description
Associated Jira ticket: # (issue)
This PR is intended to refactor the advisory systems table to make the code cleaner. The refactor only divides existing code to 2 components AdvisorySystems and AdvisorySystemsTable. AdvisorySystems is a wrapper around the table and the remediation wizard. AdvisorySystemsTable is solely for the table functionality.
It also has the tests rewritten
How to test the PR
Please include steps to test your PR.
Before the change
After the change
Dependent work link
Checklist: