JDK-8180450 article #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
force-pushed
the
dev
branch
9 times, most recently
from
921cab1 to
35f64c1
Compare
johnaohara
requested changes
Nov 22, 2022
Member
There was a problem hiding this comment.
@franz1981 , I have made some suggestions. We also need to co-ordinate creating an author profile for you
johnaohara
requested changes
Nov 22, 2022
Member
johnaohara
left a comment
johnaohara
left a comment
There was a problem hiding this comment.
@franz1981 I have added code formatting to the blog, the suggested changes will apply the code highlighting in the rendered website
Member
|
@franz1981 do you have any more changes to push? |
Contributor
Author
|
Yep, I would like to address the last comments and add a sentence about the Jdk fix + clarifying the stack register part related profilers fall |
Co-authored-by: John O'Hara <johara@redhat.com>
Co-authored-by: John O'Hara <johara@redhat.com>
Contributor
Author
|
@johnaohara I think we need a nice image to represent the article and a better title and we're ready to go :) |
Contributor
Author
|
Waiting @barreiro to look at it, maybe some sentence need some english rewording yet |
johnaohara
previously approved these changes
Nov 25, 2022
johnaohara
pushed a commit
to johnaohara/redhatperf.github.io
that referenced
this pull request
Jan 10, 2023
* JDK-8180450 article * Apply suggestions from code review Co-authored-by: John O'Hara <johara@redhat.com> * Apply youtube embed suggestion * Apply suggestions from code review Co-authored-by: John O'Hara <johara@redhat.com> * Adding mentioning JDK work and adjusting stack size * changed jdk master branch to proper commit * added Infinispan team to the party * Add scary header image * Some additional changes Co-authored-by: John O'Hara <johara@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.