Skip to content

Remove kube_v1_api function #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myakove merged 2 commits into from
Dec 14, 2022
Merged

Remove kube_v1_api function #1016

myakove merged 2 commits into from
Dec 14, 2022

Conversation

@myakove
Copy link
Collaborator

@myakove myakove commented Dec 13, 2022

kube_v1_api used only in Pod, move the logic to there.

@cnv-qe-bot cnv-qe-bot requested a review from rnetser December 13, 2022 12:27
@cnv-qe-bot cnv-qe-bot mentioned this pull request Dec 13, 2022
Closed
@cnv-qe-bot
Copy link

cnv-qe-bot commented Dec 13, 2022

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR.

Available user actions:

  • To mark PR as verified add !verified to a PR comment, to un-verify add !-verified to a PR comment.
    Verified label removed on each new commit push.
  • To cherry pick a merged PR add !cherry-pick <target branch to cherry-pick to> to a PR comment.

@myakove
Copy link
Collaborator Author

myakove commented Dec 14, 2022

!verified

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myakove myakove merged commit c109f20 into RedHatQE:main Dec 14, 2022
@myakove myakove deleted the remove-kube_v1_api-function branch December 14, 2022 07:00
@myakove
Copy link
Collaborator Author

myakove commented Dec 14, 2022

!cherry-pick v4.12

cnv-qe-bot pushed a commit that referenced this pull request Dec 14, 2022
@myakove
Remove kube_v1_api function (#1016)
85306b1
@cnv-qe-bot cnv-qe-bot mentioned this pull request Dec 14, 2022
Merged
@cnv-qe-bot
Copy link

cnv-qe-bot commented Dec 14, 2022

Cherry-picked PR Remove kube_v1_api function into v4.12

myakove added a commit that referenced this pull request Dec 14, 2022
@cnv-qe-bot @myakove
Remove kube_v1_api function (#1016) (#1025)
86817bf 
Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
myakove added a commit that referenced this pull request Aug 11, 2025
@myakove
Remove kube_v1_api function (#1016)
967e95f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnetser rnetser rnetser approved these changes

Assignees

@myakove myakove

Labels

branch-main size/XS verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myakove @cnv-qe-bot @rnetser