Skip to content

Conversation

@myakove
Copy link
Collaborator

@myakove myakove commented Aug 11, 2021

No need to wait 480 seconds if the reason is NoMatchingNode

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:

#98

Special notes for reviewer:
Bug:

@myakove
Copy link
Collaborator Author

myakove commented Aug 11, 2021

/verified

@myakove
Copy link
Collaborator Author

myakove commented Aug 12, 2021

/verified

@rnetser
Copy link
Collaborator

rnetser commented Aug 12, 2021

/approve

rnetser
rnetser previously approved these changes Aug 12, 2021
@cnv-qe-bot cnv-qe-bot dismissed rnetser’s stale review August 12, 2021 15:27

code change: Auto-dismissing Approve state

rnetser
rnetser previously approved these changes Aug 12, 2021
@cnv-qe-bot cnv-qe-bot dismissed rnetser’s stale review August 12, 2021 15:37

code change: Auto-dismissing Approve state

@rnetser
Copy link
Collaborator

rnetser commented Aug 12, 2021

/approve

No need to wait 480 seconds if the reason is NoMatchingNode
@myakove myakove force-pushed the nncp-fail-when-NoMatchingNode branch from 6c5faf9 to 5ed1995 Compare August 12, 2021 17:36
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myakove
Copy link
Collaborator Author

myakove commented Aug 12, 2021

/verified

@myakove
Copy link
Collaborator Author

myakove commented Aug 12, 2021

/approve

@myakove
Copy link
Collaborator Author

myakove commented Aug 12, 2021

/verified
/approve

@myakove
Copy link
Collaborator Author

myakove commented Aug 12, 2021

/approve

/verified

@myakove
Copy link
Collaborator Author

myakove commented Aug 12, 2021

/unverified

@myakove
Copy link
Collaborator Author

myakove commented Aug 12, 2021

/unapprove

@myakove
Copy link
Collaborator Author

myakove commented Aug 12, 2021

/verified

@myakove
Copy link
Collaborator Author

myakove commented Aug 12, 2021

/approve

@myakove myakove merged commit f9ae22f into RedHatQE:master Aug 12, 2021
@myakove myakove deleted the nncp-fail-when-NoMatchingNode branch August 12, 2021 17:51
myakove added a commit that referenced this pull request Aug 11, 2025
NNCP: Fail when reason is NoMatchingNode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants