Skip to content

NNCP: Fail when reason is NoMatchingNode #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2021
Merged

NNCP: Fail when reason is NoMatchingNode #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afe8324
NNCP: Fail when reason is NoMatchingNode
myakove Aug 11, 2021
5ed1995
Reuse vars
myakove Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ocp_resources/node_network_configuration_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class Reason:
CONFIGURING = "ConfigurationProgressing"
SUCCESS = "SuccessfullyConfigured"
FAILED = "FailedToConfigure"
NO_MATCHING_NODE = "NoMatchingNode"

def __init__(
self,
Expand Down Expand Up @@ -301,6 +302,8 @@ def status(self):
return condition["reason"]

def wait_for_status_success(self):
failed_condition_reason = self.Conditions.Reason.FAILED
no_match_node_condition_reason = self.Conditions.Reason.NO_MATCHING_NODE
# if we get here too fast there are no conditions, we need to wait.
self.wait_for_conditions()

Expand All @@ -311,7 +314,12 @@ def wait_for_status_success(self):
LOGGER.info("NNCP configured Successfully")
return sample

if sample == self.Conditions.Reason.FAILED:
if sample == no_match_node_condition_reason:
raise NNCPConfigurationFailed(
f"Reason: {no_match_node_condition_reason}"
)

if sample == failed_condition_reason:
for failed_nnce in self._get_failed_nnce():
nnce_dict = failed_nnce.instance.to_dict()
for cond in nnce_dict["status"]["conditions"]:
Expand All @@ -323,9 +331,7 @@ def wait_for_status_success(self):
f"NNCE {nnce_dict['metadata']['name']}: {error[0]}"
)

raise NNCPConfigurationFailed(
f"Reason: {self.Conditions.Reason.FAILED}"
)
raise NNCPConfigurationFailed(f"Reason: {failed_condition_reason}")

except (TimeoutExpiredError, NNCPConfigurationFailed):
LOGGER.error("Unable to configure NNCP for node")
Expand Down