add delete after completion annotation to dv #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myakove
requested changes
Dec 27, 2022
rnetser
requested changes
Dec 28, 2022
myakove
requested changes
Dec 29, 2022
Contributor
Author
|
!verified |
myakove
requested changes
Jan 3, 2023
cnv-qe-bot
added
Changes_Requested-by-myakove
and removed
Changes_Requested-by-myakove
labels
myakove
previously approved these changes
Jan 3, 2023
dalia-frank
force-pushed
the
dv_annotations
branch
from
48459a0 to
f308986
Compare
Contributor
Author
|
!verified |
rnetser
approved these changes
Jan 4, 2023
myakove
approved these changes
Jan 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
!verified |
myakove
added a commit
that referenced
this pull request
Jan 23, 2023
* add delete after completion annotation to dv (#1047) * add delete after completion annotation to dv * add docstring * fix * fix * fix docstring * fix Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com> * update Virt Launcher Pod Hypervisor Connection URI (#1054) Signed-off-by: akriti gupta <akrgupta@redhat.com> Signed-off-by: akriti gupta <akrgupta@redhat.com> Co-authored-by: akriti gupta <akrgupta@redhat.com> * add ForbiddenError to the retry list and add default exceptions to a few calls (#1058) * add ForbiddenError to the retry list * add default exceptions to a few calls * Remove code-check github action, use tox (#1065) * create endpoints resource (#1084) * create endpoints resource * Update ocp_resources/endpoints.py Co-authored-by: Ruth Netser <rnetser@redhat.com> * address review comments Co-authored-by: Ruth Netser <rnetser@redhat.com> Signed-off-by: akriti gupta <akrgupta@redhat.com> Co-authored-by: dalia-frank <65129017+dalia-frank@users.noreply.github.com> Co-authored-by: Akriti Gupta <67187004+akri3i@users.noreply.github.com> Co-authored-by: akriti gupta <akrgupta@redhat.com> Co-authored-by: Debarati Basu-Nag <dbasunag@redhat.com> Co-authored-by: Ruth Netser <rnetser@redhat.com>
myakove
added a commit
that referenced
this pull request
Aug 11, 2025
* add delete after completion annotation to dv * add docstring * fix * fix * fix docstring * fix Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug: