Skip to content

VMExport: add status Ready, remove token required #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myakove merged 1 commit into from
Jan 1, 2023
Merged

VMExport: add status Ready, remove token required #1048

myakove merged 1 commit into from
Jan 1, 2023

Conversation

@jpeimer
Copy link
Contributor

@jpeimer jpeimer commented Dec 27, 2022

Short description:
  • Add VirtualMachineExport.Status.READY
  • Remove token_secret_ref as the required field (devs changed it to be optional)

@jpeimer
Copy link
Contributor Author

jpeimer commented Dec 27, 2022

!verified

myakove
myakove approved these changes Dec 29, 2022
View reviewed changes
@myakove
Copy link
Collaborator

myakove commented Dec 29, 2022

Remove token_secret_ref as the required field (devs changed it to be optional)
Is this changed for 4.12 or 4.13?

myakove
myakove requested changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@myakove myakove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comments

rnetser
rnetser requested changes Dec 29, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jpeimer
Copy link
Contributor Author

jpeimer commented Dec 29, 2022 •
edited
Loading

Remove token_secret_ref as the required field (devs changed it to be optional) Is this changed for 4.12 or 4.13?

For both 4.12 and 4.13

@jpeimer
Copy link
Contributor Author

jpeimer commented Dec 29, 2022

!verified

@myakove myakove merged commit e0934da into RedHatQE:main Jan 1, 2023
@jpeimer
Copy link
Contributor Author

jpeimer commented Jan 1, 2023

!cherry-pick v4.12

cnv-qe-bot pushed a commit that referenced this pull request Jan 1, 2023
@jpeimer
VMExport: add status Ready, remove token required (#1048)
99fca60
@cnv-qe-bot cnv-qe-bot mentioned this pull request Jan 1, 2023
Merged
@cnv-qe-bot
Copy link

cnv-qe-bot commented Jan 1, 2023

Cherry-picked PR VMExport: add status Ready, remove token required into v4.12

myakove pushed a commit that referenced this pull request Jan 1, 2023
@cnv-qe-bot @jpeimer
VMExport: add status Ready, remove token required (#1048) (#1051)
483b1c0 
Co-authored-by: Jenia Peimer <86722603+jpeimer@users.noreply.github.com>
myakove pushed a commit that referenced this pull request Aug 11, 2025
@jpeimer
VMExport: add status Ready, remove token required (#1048)
c349188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@rnetser rnetser rnetser approved these changes

Assignees

@jpeimer jpeimer

Labels

Approved-by-myakove Approved-by-rnetser branch-main size/XS verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpeimer @myakove @cnv-qe-bot @rnetser