Add Grafana resources #1121
Closed
Add Grafana resources #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following are automatically added:
Available user actions:
|
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Feb 21, 2023
myakove
requested changes
Feb 22, 2023
| from ocp_resources.resource import NamespacedResource | ||
|
|
||
|
|
||
| class Grafana(NamespacedResource): |
Collaborator
There was a problem hiding this comment.
Empty class without to_dict implement required is not allowed.
Please introduce to_dict().
| from ocp_resources.resource import NamespacedResource | ||
|
|
||
|
|
||
| class GrafanaDataSource(NamespacedResource): |
Collaborator
There was a problem hiding this comment.
Empty class without to_dict implement required is not allowed.
Please introduce to_dict().
|
|
||
| """ | ||
| super().__init__(name=name, namespace=namespace, yaml_file=yaml_file, **kwargs) | ||
| self.label = label |
Collaborator
There was a problem hiding this comment.
All of those required? Please add verification for required args under if not self.yaml_file:
Contributor
Author
|
on hold due to recent release of v5 which altered the specs of the resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
Add Grafana Resources for grafana-operator
https://github.com/grafana-operator/grafana-operator/