auto-cherry-pick: [v4.13] Refactor job resource #1193

redhat-qe-bot · 2023-04-19T08:47:53Z

cherry-pick #1101 into v4.13

requested-by Anatw

- Add args to the docstring. - Allow background propagation policy in delete(). - Refactor daemonset.py delete() to return the result. Signed-off-by: Anat Wax <awax@redhat.com>

redhat-qe-bot · 2023-04-19T08:47:56Z

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)

Available user actions:

To mark PR as verified add /verified to a PR comment, to un-verify add /verified cancel to a PR comment.
verified label removed on each new commit push.
To cherry pick a merged PR add /cherry-pick <target branch to cherry-pick to> to a PR comment.
- Support only merged PRs
To add a label by comment use /<label name>, to remove, use /<label name> cancel

Supported labels

hold
verified
wip
lgtm
approve
target-version-

sonarqubecloud · 2023-04-19T08:48:22Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

redhat-qe-bot · 2023-04-19T08:48:28Z

Tox check passed

�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
⠋ [1/2] unittests
�[K
⠙ [1/2] unittests
�[K
⠹ [1/2] unittests
�[K
⠸ [1/2] unittests
�[K
⠼ [1/2] unittests
�[K
⠴ [1/2] unittests
�[K
⠦ [1/2] unittests
�[K
⠧ [1/2] unittests
�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
⠋ [1/2] unittests
�[K
⠙ [1/2] unittests
�[K
⠹ [1/2] unittests
�[K
⠸ [1/2] unittests
�[K
⠼ [1/2] unittests
�[K
⠴ [1/2] unittests
�[K
⠦ [1/2] unittests
�[K
⠧ [1/2] unittests
�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
⠋ [1/2] unittests
�[K
⠙ [1/2] unittests
�[K
⠹ [1/2] unittests
�[K
⠸ [1/2] unittests
�[K
⠼ [1/2] unittests
�[K
⠴ [1/2] unittests
�[K
⠦ [1/2] unittests
�[K
⠧ [1/2] unittests
�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
⠋ [1/2] unittests
�[K
⠙ [1/2] unittests
�[K
⠹ [1/2] unittests
�[K
⠸ [1/2] unittests
�[K
⠼ [1/2] unittests
�[K
⠴ [1/2] unittests
�[K
⠦ [1/2] unittests
�[K
⠧ [1/2] unittests
�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
⠋ [1/2] unittests
�[K
⠙ [1/2] unittests
�[K
�[K unittests: OK (18.12=setup[1.47]+cmd[11.54,5.12] seconds)
validate-resources: OK (13.78=setup[2.14]+cmd[11.19,0.45] seconds)
congratulations :) (18.17 seconds)

omrirh · 2023-04-23T09:38:42Z

/lgtm

Anatw · 2023-05-07T05:53:49Z

/verified

sonarqubecloud · 2023-06-01T14:00:44Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

myakove · 2023-06-01T14:19:53Z

/lgtm

Refactor job and daemonset resources (#1101)

5fd05d4

- Add args to the docstring. - Allow background propagation policy in delete(). - Refactor daemonset.py delete() to return the result. Signed-off-by: Anat Wax <awax@redhat.com>

redhat-qe-bot added the auto-cherry-pick label Apr 19, 2023

redhat-qe-bot added size/S branch-v4.13 labels Apr 19, 2023

redhat-qe-bot requested review from myakove and rnetser April 19, 2023 08:48

redhat-qe-bot mentioned this pull request Apr 19, 2023

auto-cherry-pick: [v4.13] Refactor job resource - 1193 #1194

Closed

rnetser approved these changes Apr 19, 2023

View reviewed changes

redhat-qe-bot added the Approved-by-rnetser label Apr 19, 2023

redhat-qe-bot added the Approved-by-omrirh label Apr 23, 2023

myakove approved these changes Apr 24, 2023

View reviewed changes

redhat-qe-bot added the Approved-by-myakove label Apr 24, 2023

redhat-qe-bot added verified needs-rebase and removed needs-rebase labels May 7, 2023

redhat-qe-bot added needs-rebase and removed needs-rebase labels May 15, 2023

Merge branch 'v4.13' into auto-cherry-pick-refactor_job_resource

784ef54

redhat-qe-bot requested review from myakove and rnetser June 1, 2023 13:27

redhat-qe-bot removed Approved-by-myakove Approved-by-rnetser labels Jun 1, 2023

redhat-qe-bot removed the Approved-by-omrirh label Jun 1, 2023

redhat-qe-bot added Approved-by-myakove can-be-merged labels Jun 1, 2023

myakove merged commit ef2f2a8 into v4.13 Jun 1, 2023

myakove deleted the auto-cherry-pick-refactor_job_resource branch June 1, 2023 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

auto-cherry-pick: [v4.13] Refactor job resource #1193

auto-cherry-pick: [v4.13] Refactor job resource #1193

Uh oh!

redhat-qe-bot commented Apr 19, 2023

Uh oh!

redhat-qe-bot commented Apr 19, 2023

Uh oh!

sonarqubecloud bot commented Apr 19, 2023

Uh oh!

redhat-qe-bot commented Apr 19, 2023

Uh oh!

omrirh commented Apr 23, 2023

Uh oh!

Anatw commented May 7, 2023

Uh oh!

sonarqubecloud bot commented Jun 1, 2023

Uh oh!

myakove commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

auto-cherry-pick: [v4.13] Refactor job resource #1193

auto-cherry-pick: [v4.13] Refactor job resource #1193

Uh oh!

Conversation

redhat-qe-bot commented Apr 19, 2023

Uh oh!

redhat-qe-bot commented Apr 19, 2023

Uh oh!

sonarqubecloud bot commented Apr 19, 2023

Uh oh!

redhat-qe-bot commented Apr 19, 2023

Uh oh!

omrirh commented Apr 23, 2023

Uh oh!

Anatw commented May 7, 2023

Uh oh!

sonarqubecloud bot commented Jun 1, 2023

Uh oh!

myakove commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants