Refactor the code according to flake8 errors #1205

Anatw · 2023-04-30T15:26:37Z

Short description:

More details:

flake8...................................................................Failed

hook id: flake8
exit code: 1

ocp_resources/node.py:16:16: C419 Unnecessary list comprehension passed to any() prevents short-circuiting - rewrite as a generator.
ocp_resources/virtual_machine_restore.py:72:26: SIM910 Use 'self.instance.get('status', {}).get("complete")' instead of 'self.instance.get('status', {}).get('complete', None)'
ocp_resources/virtual_machine_snapshot.py:69:26: SIM910 Use 'self.instance.get('status', {}).get("readyToUse")' instead of 'self.instance.get('status', {}).get('readyToUse', None)'

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

Bug:

Signed-off-by: Anat Wax <awax@redhat.com>

redhat-qe-bot · 2023-04-30T15:26:40Z

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)

Available user actions:

To mark PR as verified add /verified to a PR comment, to un-verify add /verified cancel to a PR comment.
verified label removed on each new commit push.
To cherry pick a merged PR add /cherry-pick <target branch to cherry-pick to> to a PR comment.
- Support only merged PRs
To add a label by comment use /<label name>, to remove, use /<label name> cancel

Supported labels

hold
verified
wip
lgtm
approve
target-version-

sonarqubecloud · 2023-04-30T15:27:02Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

redhat-qe-bot · 2023-04-30T15:27:13Z

Tox check passed

�[K
⠹ [1/2] unittests
�[K
⠸ [1/2] unittests
�[K
⠼ [1/2] unittests
�[K
⠴ [1/2] unittests
�[K
⠦ [1/2] unittests
�[K
⠧ [1/2] unittests
�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
⠋ [1/2] unittests
�[K
⠙ [1/2] unittests
�[K
⠹ [1/2] unittests
�[K
⠸ [1/2] unittests
�[K
⠼ [1/2] unittests
�[K
⠴ [1/2] unittests
�[K
⠦ [1/2] unittests
�[K
⠧ [1/2] unittests
�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
⠋ [1/2] unittests
�[K
⠙ [1/2] unittests
�[K
⠹ [1/2] unittests
�[K
⠸ [1/2] unittests
�[K
⠼ [1/2] unittests
�[K
⠴ [1/2] unittests
�[K
⠦ [1/2] unittests
�[K
⠧ [1/2] unittests
�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
⠋ [1/2] unittests
�[K
⠙ [1/2] unittests
�[K
⠹ [1/2] unittests
�[K
⠸ [1/2] unittests
�[K
⠼ [1/2] unittests
�[K
⠴ [1/2] unittests
�[K
⠦ [1/2] unittests
�[K
⠧ [1/2] unittests
�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
⠋ [1/2] unittests
�[K
⠙ [1/2] unittests
�[K
⠹ [1/2] unittests
�[K
⠸ [1/2] unittests
�[K
⠼ [1/2] unittests
�[K
⠴ [1/2] unittests
�[K
⠦ [1/2] unittests
�[K
⠧ [1/2] unittests
�[K
⠇ [1/2] unittests
�[K
⠏ [1/2] unittests
�[K
�[K unittests: OK (20.00=setup[1.46]+cmd[0.85,12.56,5.13] seconds)
validate-resources: OK (15.13=setup[1.77]+cmd[0.88,11.89,0.59] seconds)
congratulations :) (20.07 seconds)

Anatw · 2023-05-01T09:07:03Z

/verified

Anatw · 2023-05-03T09:20:35Z

/cherry-pick v4.13

Signed-off-by: Anat Wax <awax@redhat.com>

redhat-qe-bot · 2023-05-03T09:20:46Z

Cherry-picked PR Refactor the code according to flake8 errors into v4.13

Signed-off-by: Anat Wax <awax@redhat.com> Co-authored-by: ‪Anat Wax <46938838+Anatw@users.noreply.github.com>

Signed-off-by: Anat Wax <awax@redhat.com>

Refactor the code according to flake8 errors

bcd11f5

Signed-off-by: Anat Wax <awax@redhat.com>

redhat-qe-bot added size/XS branch-main labels Apr 30, 2023

redhat-qe-bot assigned Anatw Apr 30, 2023

redhat-qe-bot requested review from myakove and rnetser April 30, 2023 15:26

myakove approved these changes May 1, 2023

View reviewed changes

redhat-qe-bot added the Approved-by-myakove label May 1, 2023

redhat-qe-bot added the verified label May 1, 2023

myakove merged commit 633140b into RedHatQE:main May 2, 2023

Anatw deleted the fix_errors_by_flake8 branch May 2, 2023 09:34

redhat-qe-bot pushed a commit that referenced this pull request May 3, 2023

Refactor the code according to flake8 errors (#1205)

9c34c8c

Signed-off-by: Anat Wax <awax@redhat.com>

redhat-qe-bot mentioned this pull request May 3, 2023

auto-cherry-pick: [v4.13] Refactor the code according to flake8 errors #1209

Merged

rnetser pushed a commit that referenced this pull request May 4, 2023

Refactor the code according to flake8 errors (#1205) (#1209)

e07cc1a

Signed-off-by: Anat Wax <awax@redhat.com> Co-authored-by: ‪Anat Wax <46938838+Anatw@users.noreply.github.com>

Anatw added a commit to Anatw/openshift-python-wrapper that referenced this pull request Jun 15, 2023

Refactor the code according to flake8 errors (RedHatQE#1205)

36f1d68

Signed-off-by: Anat Wax <awax@redhat.com>

myakove pushed a commit that referenced this pull request Jun 18, 2023

Refactor the code according to flake8 errors (#1205) (#1243)

da7ae97

Signed-off-by: Anat Wax <awax@redhat.com>

myakove pushed a commit that referenced this pull request Aug 11, 2025

Refactor the code according to flake8 errors (#1205)

78ba276

Signed-off-by: Anat Wax <awax@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor the code according to flake8 errors #1205

Refactor the code according to flake8 errors #1205

Uh oh!

Anatw commented Apr 30, 2023

Uh oh!

redhat-qe-bot commented Apr 30, 2023

Uh oh!

sonarqubecloud bot commented Apr 30, 2023

Uh oh!

redhat-qe-bot commented Apr 30, 2023

Uh oh!

Anatw commented May 1, 2023

Uh oh!

Anatw commented May 3, 2023

Uh oh!

redhat-qe-bot commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Refactor the code according to flake8 errors #1205

Refactor the code according to flake8 errors #1205

Uh oh!

Conversation

Anatw commented Apr 30, 2023

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

Bug:

Uh oh!

redhat-qe-bot commented Apr 30, 2023

Uh oh!

sonarqubecloud bot commented Apr 30, 2023

Uh oh!

redhat-qe-bot commented Apr 30, 2023

Uh oh!

Anatw commented May 1, 2023

Uh oh!

Anatw commented May 3, 2023

Uh oh!

redhat-qe-bot commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants