Skip to content

auto-cherry-pick: [v4.13] Support different API groups for resources with the same kind #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

auto-cherry-pick: [v4.13] Support different API groups for resources with the same kind #1217

merged 1 commit into from
May 10, 2023

Conversation

@redhat-qe-bot
Copy link
Contributor

@redhat-qe-bot redhat-qe-bot commented May 10, 2023

cherry-pick #1215 into v4.13

requested-by rnetser

@redhat-qe-bot
Copy link
Contributor Author

redhat-qe-bot commented May 10, 2023

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)

Available user actions:

  • To mark PR as verified add /verified to a PR comment, to un-verify add /verified cancel to a PR comment.
    verified label removed on each new commit push.
  • To cherry pick a merged PR add /cherry-pick <target branch to cherry-pick to> to a PR comment.
    • Support only merged PRs
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • target-version-

@redhat-qe-bot redhat-qe-bot requested review from myakove and rnetser May 10, 2023 10:51
@redhat-qe-bot redhat-qe-bot mentioned this pull request May 10, 2023
Closed
@rnetser
Copy link
Collaborator

rnetser commented May 10, 2023

/verified

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myakove myakove merged commit c1e2817 into v4.13 May 10, 2023
@myakove myakove deleted the auto-cherry-pick-api_group branch May 10, 2023 10:52
@rnetser
Copy link
Collaborator

rnetser commented May 10, 2023

@Anatw this should address the issue with Network resource

@rnetser
Copy link
Collaborator

rnetser commented May 10, 2023

/cherry-pick v4.12

1 similar comment
@rnetser
Copy link
Collaborator

rnetser commented May 10, 2023

/cherry-pick v4.12

redhat-qe-bot added a commit that referenced this pull request May 10, 2023
@redhat-qe-bot @rnetser
Resources - support different API groups for resources with the same …
0acb65b 
…Kind (#1215) (#1217)

Co-authored-by: Ruth Netser <rnetser@redhat.com>
@redhat-qe-bot redhat-qe-bot mentioned this pull request May 10, 2023
Merged
@redhat-qe-bot
Copy link
Contributor Author

redhat-qe-bot commented May 10, 2023

Cherry-picked PR auto-cherry-pick: [v4.13] Support different API groups for resources with the same kind into v4.12

myakove pushed a commit to myakove/openshift-python-wrapper that referenced this pull request May 10, 2023
@redhat-qe-bot @rnetser @myakove
Resources - support different API groups for resources with the same …
43dcabd 
…Kind (RedHatQE#1215) (RedHatQE#1217)

Co-authored-by: Ruth Netser <rnetser@redhat.com>
myakove added a commit that referenced this pull request May 10, 2023
@redhat-qe-bot @rnetser @myakove
Resources - support different API groups for resources with the same …
7e97ad8 
…Kind (#1215) (#1217) (#1219)

Co-authored-by: Ruth Netser <rnetser@redhat.com>
Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@rnetser rnetser Awaiting requested review from rnetser

Assignees

@rnetser rnetser

Labels

Approved-by-myakove auto-cherry-pick branch-v4.13 size/XS verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@redhat-qe-bot @rnetser @myakove