Skip to content

Resource.get - add option to pass exceptions_dict #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rnetser merged 1 commit into from
Aug 30, 2023
Merged

Resource.get - add option to pass exceptions_dict #1370

rnetser merged 1 commit into from
Aug 30, 2023

Conversation

@rnetser
Copy link
Collaborator

@rnetser rnetser commented Aug 29, 2023

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Aug 29, 2023

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@redhat-qe-bot redhat-qe-bot mentioned this pull request Aug 29, 2023
Closed
@rnetser rnetser mentioned this pull request Aug 29, 2023
Merged
@rnetser rnetser mentioned this pull request Aug 29, 2023
Merged
@rnetser
Copy link
Collaborator Author

rnetser commented Aug 29, 2023

/cherry-pick v4.14
/cherry-pick v4.13

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Aug 29, 2023

Cherry-pick requested for PR: Resource.get - add option to pass exceptions_dict by user rnetser
Adding label/s cherry-pick-v4.14 for automatic cheery-pick once the PR is merged

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Aug 29, 2023

Cherry-pick requested for PR: Resource.get - add option to pass exceptions_dict by user rnetser
Adding label/s cherry-pick-v4.13 for automatic cheery-pick once the PR is merged

@rnetser
Copy link
Collaborator Author

rnetser commented Aug 30, 2023

/verified

@rnetser rnetser merged commit 461d1bc into RedHatQE:main Aug 30, 2023
@redhat-qe-bot redhat-qe-bot mentioned this pull request Aug 30, 2023
Merged
redhat-qe-bot pushed a commit that referenced this pull request Aug 30, 2023
@rnetser
Resource.get - add option to pass exceptions_dict (#1370)
c4a0739
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Aug 30, 2023

Cherry-picked PR Resource.get - add option to pass exceptions_dict into v4.14

@redhat-qe-bot redhat-qe-bot mentioned this pull request Aug 30, 2023
Merged
redhat-qe-bot pushed a commit that referenced this pull request Aug 30, 2023
@rnetser
Resource.get - add option to pass exceptions_dict (#1370)
d8ca76c
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Aug 30, 2023

Cherry-picked PR Resource.get - add option to pass exceptions_dict into v4.13

redhat-qe-bot added a commit that referenced this pull request Aug 30, 2023
@redhat-qe-bot @rnetser @pre-commit-ci
CherryPicked: [v4.14] Resource.get - add option to pass exceptions_di…
0816c32 
…ct (#1372)

* Resource.get - add option to pass exceptions_dict (#1370)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Ruth Netser <rnetser@redhat.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
myakove pushed a commit that referenced this pull request Aug 30, 2023
@redhat-qe-bot @rnetser @pre-commit-ci
CherryPicked: [v4.13] Resource.get - add option to pass exceptions_di…
1752a49 
…ct (#1373)

* Resource.get - add option to pass exceptions_dict (#1370)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Ruth Netser <rnetser@redhat.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
myakove pushed a commit that referenced this pull request Aug 11, 2025
@rnetser
Resource.get - add option to pass exceptions_dict (#1370)
4e017cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@omrirh omrirh Awaiting requested review from omrirh

@oharan2 oharan2 Awaiting requested review from oharan2

Assignees

@rnetser rnetser

Labels

ApprovedBy-myakove branch-main can-be-merged cherry-pick-v4.13 cherry-pick-v4.14 size/XS verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rnetser @redhat-qe-bot @myakove