Skip to content

Add prime pvc property #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Add prime pvc property #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53ab020
Add prime pvc property
dalia-frank Sep 18, 2023
d9fbcb1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 18, 2023
df89646
Merge branch 'main' into prime_pvc
dalia-frank Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ocp_resources/datavolume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,7 @@ def pvc(self):
@property
def scratch_pvc(self):
scratch_pvc_prefix = (
f"prime-{self.pvc.instance.metadata.uid}"
if self.pvc.use_populator
else self.name
self.pvc.prime_pvc.name if self.pvc.use_populator else self.name
)
return PersistentVolumeClaim(
name=f"{scratch_pvc_prefix}-scratch",
Expand Down
9 changes: 9 additions & 0 deletions ocp_resources/persistent_volume_claim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,12 @@ def use_populator(self):
)
== "true"
)

@property
def prime_pvc(self):
if self.use_populator:
return PersistentVolumeClaim(
name=f"prime-{self.instance.metadata.uid}",
namespace=self.namespace,
client=self.client,
)