Skip to content

Conversation

@hmeir
Copy link
Contributor

@hmeir hmeir commented Jan 28, 2024

  • Add snapshot property to Datasource class

  • Add deprecation warning for DataSource pvc property

* Add snapshot property to Datasource class

Signed-off-by: Harel Meir <hmeir@redhat.com>

* Add deprecation warning for DataSource pvc property

Signed-off-by: Harel Meir <hmeir@redhat.com>

---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
@redhat-qe-bot1
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@hmeir
Copy link
Contributor Author

hmeir commented Jan 29, 2024

/verified

@myakove
Copy link
Collaborator

myakove commented Jan 29, 2024

/retest tox

@myakove
Copy link
Collaborator

myakove commented Jan 29, 2024

/retest python-module-install

@myakove myakove enabled auto-merge (squash) January 29, 2024 09:25
@myakove myakove merged commit e78f80d into RedHatQE:v4.15 Jan 29, 2024
@hmeir
Copy link
Contributor Author

hmeir commented Jan 29, 2024

/cherry-pick v4.14

@redhat-qe-bot1
Copy link

Manual cherry-pick is needed
Cherry pick failed for e78f80d to v4.14:
To cherry-pick run:

git remote update
git checkout v4.14
git pull origin v4.14
git checkout -b datasource-snapshot-prop-v4.15-v4.14
git cherry-pick e78f80da7ead4660da95ada6752b35883336fa39
git push origin datasource-snapshot-prop-v4.15-v4.14

myakove pushed a commit that referenced this pull request Jan 30, 2024
* Add snapshot property to Datasource class

* Add deprecation warning for DataSource pvc property

---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
Co-authored-by: Ruth Netser <rnetser@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants