Skip to content

Conversation

@Ahmad-Hafe
Copy link
Contributor

@Ahmad-Hafe Ahmad-Hafe commented Feb 6, 2024

Short description:
adding Scheduled phase to VMI

More details:
adding Scheduled phase to VMI because its missing, and need to test all phases for T2 tests

What this PR does / why we need it:
require to add Scheduled phase in order to test T2

Which issue(s) this PR fixes:
Fixing the needs to inheritance the Scheduled phase rather than hard code

Special notes for reviewer:
none

Bug:
none

@redhat-qe-bot
Copy link
Contributor

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@myakove
Copy link
Collaborator

myakove commented Feb 6, 2024

/hold

base commit is old

* ba3910e5 - (HEAD, origin/pr/1645) adding Scheduled phase to vmi (2 hours ago) <Ahmad Hafe>
* f5002170 - WaitingForVolumeBinding VM status (#835) (1 year, 4 months ago) <Adolfo Aguirrezabal>

@redhat-qe-bot1
Copy link

Label pr is not a predefined one, will not be added / removed.
Available labels:

  • hold
  • verified
  • wip
  • lgtm

@redhat-qe-bot1
Copy link

Label 1645) is not a predefined one, will not be added / removed.
Available labels:

  • hold
  • verified
  • wip
  • lgtm

@myakove
Copy link
Collaborator

myakove commented Feb 6, 2024

/hold

@Ahmad-Hafe
Copy link
Contributor Author

/verified

@myakove
Copy link
Collaborator

myakove commented Feb 11, 2024

/lgtm

@myakove
Copy link
Collaborator

myakove commented Feb 11, 2024

/hold cancel

@Ahmad-Hafe
Copy link
Contributor Author

/verified

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ahmad-Hafe
Copy link
Contributor Author

/verified

@myakove myakove merged commit 03b44ec into RedHatQE:main Feb 13, 2024
myakove pushed a commit that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants