Skip to content

api version - use class attr and extract api group from api version #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myakove merged 9 commits into from
Jul 28, 2024
Merged

api version - use class attr and extract api group from api version #1935

myakove merged 9 commits into from
Jul 28, 2024

Conversation

@rnetser
Copy link
Collaborator

@rnetser rnetser commented Jul 25, 2024

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Jul 25, 2024

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@redhat-qe-bot redhat-qe-bot mentioned this pull request Jul 25, 2024
Closed
@redhat-qe-bot redhat-qe-bot requested a review from myakove July 25, 2024 13:27
@redhat-qe-bot redhat-qe-bot requested a review from omrirh July 25, 2024 13:27
@rnetser rnetser changed the title api version - use class attr and extract api group from api version wip: api version - use class attr and extract api group from api version Jul 25, 2024
@rnetser rnetser changed the title wip: api version - use class attr and extract api group from api version api version - use class attr and extract api group from api version Jul 25, 2024
myakove
myakove requested changes Jul 25, 2024
View reviewed changes
@redhat-qe-bot redhat-qe-bot requested a review from myakove July 25, 2024 17:47
@myakove
Copy link
Collaborator

myakove commented Jul 26, 2024

/verified

myakove
myakove previously approved these changes Jul 26, 2024
View reviewed changes
@redhat-qe-bot redhat-qe-bot requested a review from myakove July 26, 2024 18:24
myakove
myakove previously approved these changes Jul 28, 2024
View reviewed changes
@myakove
Copy link
Collaborator

myakove commented Jul 28, 2024

/verified

@redhat-qe-bot2 redhat-qe-bot2 requested a review from myakove July 28, 2024 05:29
@myakove
Copy link
Collaborator

myakove commented Jul 28, 2024

/verified

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 28, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@myakove
Copy link
Collaborator

myakove commented Jul 28, 2024

/verified

@myakove myakove merged commit c8df431 into main Jul 28, 2024
@myakove myakove deleted the fix-api-version branch July 28, 2024 06:33
myakove added a commit that referenced this pull request Aug 11, 2025
@rnetser @myakove
api version - use class attr and extract api group from api version (#…
32c458b 
…1935)

* resolve conflicts

* fix comment

* Use split, not re. add some tests

* Use split, not re. add some tests

* ENable debug to file, remove verbos

* Added support for running script from debug file and improved interactive mode functionality

* Update .gitignore to ignore class generator script debug files

* Update README.md to reflect latest oc/kubectl version requirement, add open issue instractions

* feat: add debug output file path to resource class generator

---------

Co-authored-by: Meni Yakove <myakove@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@omrirh omrirh Awaiting requested review from omrirh

Assignees

No one assigned

Labels

approved-myakove branch-main can-be-merged JIRA:MSINTEROP-1251 size/XXL verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rnetser @redhat-qe-bot @myakove @redhat-qe-bot1 @redhat-qe-bot2 @rh-bot-1