-
Notifications
You must be signed in to change notification settings - Fork 68
CherryPicked: [v4.20] fix: Update VMI pause/unpause #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CherryPicked: [v4.20] fix: Update VMI pause/unpause #2602
Conversation
removed wait_for_domstate_pause_status from pause/unpause
(when called with wait=True):
1. check for domstate was an old w/a with is irrelevant now
2. executing domstate command on virt-launhcer pod can be done
only with admin client (even though pause/unpause can be
executed by unpriv client)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features:
🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
/lgtm |
cherry-pick #2596 into v4.20
requested-by SamAlber