fix(deps): pin kubernetes!=36.0.0 due to broken bearer-token auth#2732
Merged
Conversation
kubernetes v36.0.0 has a regression where auth_settings() no longer recognizes the 'authorization' key in api_key, silently dropping the Authorization header from all API requests. The upstream fix (PR #2585) is merged but not yet released. Exclude 36.0.0 until a patched v36.x ships. Ref: kubernetes-client/python#2582
Review Summary by QodoPin kubernetes!=36.0.0 to avoid broken bearer-token auth
WalkthroughsDescription• Pin kubernetes dependency to exclude v36.0.0 due to bearer-token auth regression • v36.0.0 breaks Authorization header handling in API requests • Upstream fix merged but not yet released in v36.x • Added inline comment with issue reference for future removal Diagramflowchart LR
A["kubernetes v36.0.0<br/>broken bearer-token auth"] -->|"regression in<br/>auth_settings()"| B["Authorization header<br/>silently dropped"]
B -->|"causes"| C["401/403 errors<br/>on API calls"]
D["Pin kubernetes<br/>!=36.0.0"] -->|"excludes"| A
D -->|"allows"| E["v31.0.0 to v35.x<br/>and v36.0.1+"]
File Changes1. pyproject.toml
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
rh-bot-1
changed the title
python-benedict 0.34.0 dropped Python 3.9 support, using str|bytes union syntax that requires Python 3.10+. Pin to <0.34.0 since v4.19 CI still tests against Python 3.9.
The project now requires Python 3.10 or later. This allows removing version-specific dependency pins and conditional resolution markers throughout the lock file, significantly simplifying dependency management. Removed python-fsutil dependency and updated python-benedict to remove its upper version bound since it now supports Python 3.10+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
kubernetesdependency to>=31.0.0,!=36.0.0to avoid a broken bearer-token auth regression in v36.0.0.Why
kubernetes v36.0.0 has a regression where
Configuration.auth_settings()no longer recognizes theauthorizationkey inapi_key, silently dropping theAuthorizationheader from all API requests. This causes 401/403 errors for any authenticated API call.The upstream fix (kubernetes-client/python#2585) is merged but not yet released. Exclude 36.0.0 until a patched v36.x ships.
Ref: kubernetes-client/python#2582
Done
kubernetes!=36.0.0inpyproject.tomluv lock --upgrade