add wait argument to deploy() #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myakove
requested changes
Apr 12, 2022
| sys.exit(signal_received) | ||
|
|
||
| def deploy(self): | ||
| def deploy(self, wait=False): |
Collaborator
There was a problem hiding this comment.
We have more resources that define wait, please add wait there as well.
Contributor
Author
There was a problem hiding this comment.
I will update those resources.
myakove
requested changes
Apr 14, 2022
| return | ||
|
|
||
| def deploy(self): | ||
| def deploy(self, wait=True): |
Collaborator
There was a problem hiding this comment.
wait should go to self.create() and not with if wait:
|
Kudos, SonarCloud Quality Gate passed!
|
myakove
approved these changes
Apr 14, 2022
| return | ||
|
|
||
| def deploy(self): | ||
| def deploy(self, wait=True): |
Collaborator
There was a problem hiding this comment.
wait should go to self.create() and not with if wait:
Contributor
Author
|
!verified |
myakove
approved these changes
Apr 20, 2022
dbasunag
added a commit
to dbasunag/openshift-python-wrapper
that referenced
this pull request
Apr 24, 2022
* add wait argument to deploy() * update node_network_configuration_policy.deploy() * pass wait argument to the create call * change default value to False
rnetser
added a commit
that referenced
this pull request
May 2, 2022
add wait argument to deploy() (#499)
myakove
pushed a commit
to myakove/openshift-python-wrapper
that referenced
this pull request
May 11, 2022
* add wait argument to deploy() * update node_network_configuration_policy.deploy() * pass wait argument to the create call * change default value to False
myakove
added a commit
that referenced
this pull request
May 11, 2022
myakove
pushed a commit
that referenced
this pull request
Aug 11, 2025
* add wait argument to deploy() * update node_network_configuration_policy.deploy() * pass wait argument to the create call * change default value to False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description: Added wait=False to resource.deploy() call
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug: