Skip to content

add wait argument to deploy() #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2022
Merged

add wait argument to deploy() #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23517a4
add wait argument to deploy()
dbasunag Apr 11, 2022
614b682
update node_network_configuration_policy.deploy()
dbasunag Apr 12, 2022
e566837
pass wait argument to the create call
dbasunag Apr 14, 2022
d2323af
change default value to False
dbasunag Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ocp_resources/node_network_configuration_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,11 @@ def apply(self, resource=None):
for _ in samples:
return

def deploy(self):
def deploy(self, wait=False):
self.ipv4_ports_backup()
self.ipv6_ports_backup()

self.create(body=self.res)
self.create(body=self.res, wait=wait)
try:
self.wait_for_status_success()
return self
Expand Down
4 changes: 2 additions & 2 deletions ocp_resources/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,8 @@ def _sigint_handler(self, signal_received, frame):
self.__exit__(exception_type=None, exception_value=None, traceback=None)
sys.exit(signal_received)

def deploy(self):
self.create()
def deploy(self, wait=False):
Copy link
Collaborator

@myakove myakove Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have more resources that define wait, please add wait there as well.

Copy link
Contributor Author

@dbasunag dbasunag Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update those resources.

self.create(wait=wait)
return self

def clean_up(self):
Expand Down