Skip to content

Do not require live cluster only for create class instance #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 5 commits into from
Aug 11, 2022
Merged

Do not require live cluster only for create class instance #731

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
451347f
Do not require live cluster only for create class instance
myakove Aug 4, 2022
58a8747
set version and client when needed
myakove Aug 4, 2022
6bd3994
Merge branch 'main' into no-need-cluster-for-class-object
myakove Aug 7, 2022
2ff4491
Merge branch 'main' into no-need-cluster-for-class-object
myakove Aug 8, 2022
e0692b1
Merge branch 'main' into no-need-cluster-for-class-object
myakove Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions ocp_resources/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,16 +339,6 @@ def __init__(
if not (self.name or self.yaml_file):
raise ValueError("name or yaml file is required")

if not self.client:
self.client = _get_client(
config_file=self.config_file, context=self.context
)

if not self.api_version:
self.api_version = _get_api_version(
dyn_client=self.client, api_group=self.api_group, kind=self.kind
)

self.teardown = teardown
self.timeout = timeout
self.delete_timeout = delete_timeout
Expand Down Expand Up @@ -388,6 +378,7 @@ def _base_body(self):
self.resource_dict.get("metadata", {}).pop("resourceVersion", None)
self.name = self.resource_dict["metadata"]["name"]
else:
self._set_client_and_api_version()
self.resource_dict = {
"apiVersion": self.api_version,
"kind": self.kind,
Expand Down Expand Up @@ -500,6 +491,17 @@ def _prepare_singular_name_kwargs(self, **kwargs):

return kwargs

def _set_client_and_api_version(self):
if not self.client:
self.client = _get_client(
config_file=self.config_file, context=self.context
)

if not self.api_version:
self.api_version = _get_api_version(
dyn_client=self.client, api_group=self.api_group, kind=self.kind
)

def full_api(self, **kwargs):
"""
Get resource API
Expand All @@ -519,6 +521,8 @@ def full_api(self, **kwargs):
Returns:
Resource: Resource object.
"""
self._set_client_and_api_version()

kwargs = self._prepare_singular_name_kwargs(**kwargs)

return self.client.resources.get(
Expand Down