Skip to content

Conversation

@OhadRevah
Copy link
Contributor

@OhadRevah OhadRevah commented Aug 23, 2022

Short description:Adding two pod status: "ImagePullBackOff" and "ErrImagePull"
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@rnetser rnetser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the description goes into the release notes, please update to a more descriptive description of the PR

@OhadRevah
Copy link
Contributor Author

@rnetser please let me know if the current description is OK

@rnetser
Copy link
Collaborator

rnetser commented Aug 24, 2022

@OhadRevah The PR's title should be updated as well

@OhadRevah OhadRevah changed the title Updated the branch and add again the pod statuses Updated the branch and add again the pod statuses "ImagePullBackOff" and "ErrImagePull" Aug 25, 2022
@OhadRevah
Copy link
Contributor Author

Updated the title, please let me know if the current title is ok

Copy link
Collaborator

@rnetser rnetser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be something like:

Add "ImagePullBackOff" and "ErrImagePull" pod statuses

@OhadRevah OhadRevah changed the title Updated the branch and add again the pod statuses "ImagePullBackOff" and "ErrImagePull" Add "ImagePullBackOff" and "ErrImagePull" pod statuses Aug 25, 2022
@OhadRevah
Copy link
Contributor Author

Updated the title

@OhadRevah
Copy link
Contributor Author

!verified

@myakove myakove merged commit 3c03b38 into RedHatQE:main Aug 28, 2022
@OhadRevah
Copy link
Contributor Author

!cherry-pick v4.11

@cnv-qe-bot
Copy link

Cherry-picked PR Add "ImagePullBackOff" and "ErrImagePull" pod statuses into v4.11

myakove pushed a commit that referenced this pull request Aug 28, 2022
Co-authored-by: Ohad Revah <orevah@redhat.com>
@OhadRevah OhadRevah deleted the add_pod_state branch December 23, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants