Skip to content

rename all res to self.res #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myakove merged 6 commits into from
Nov 14, 2022
Merged

rename all res to self.res #945

myakove merged 6 commits into from
Nov 14, 2022

Conversation

@myakove
Copy link
Collaborator

@myakove myakove commented Nov 3, 2022

Rename all res to self.res to be consistent with the code.

@cnv-qe-bot cnv-qe-bot requested a review from rnetser November 3, 2022 12:47
@cnv-qe-bot cnv-qe-bot mentioned this pull request Nov 3, 2022
Closed
@cnv-qe-bot
Copy link

cnv-qe-bot commented Nov 3, 2022

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR.

Available user actions:

  • To mark PR as verified add !verified to a PR comment, to un-verify add !-verified to a PR comment.
    Verified label removed on each new commit push.
  • To cherry pick a merged PR add !cherry-pick <target branch to cherry-pick to> to a PR comment.

rnetser
rnetser reviewed Nov 4, 2022
View reviewed changes
@myakove
Copy link
Collaborator Author

myakove commented Nov 7, 2022

!DO-NOT-MERGE

@myakove myakove mentioned this pull request Nov 10, 2022
Merged
@myakove
Copy link
Collaborator Author

myakove commented Nov 11, 2022

!-DO-NOT-MERGE

rnetser
rnetser requested changes Nov 14, 2022
View reviewed changes
@myakove
Copy link
Collaborator Author

myakove commented Nov 14, 2022

!verified

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myakove
Copy link
Collaborator Author

myakove commented Nov 14, 2022

!verified

@myakove myakove merged commit 79030e0 into RedHatQE:main Nov 14, 2022
@myakove myakove deleted the res-to-self.res branch November 14, 2022 15:53
@myakove
Copy link
Collaborator Author

myakove commented Nov 14, 2022

!cherry-pick v4.12

1 similar comment
@myakove
Copy link
Collaborator Author

myakove commented Nov 14, 2022

!cherry-pick v4.12

@cnv-qe-bot
Copy link

cnv-qe-bot commented Nov 14, 2022

Manual cherry-pick is needed
Cherry pick failed for 79030e0 to v4.12:
error: could not apply 79030e0... rename all res to self.res (#945)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

To cherry-pick run:

git checkout v4.12
git checkout -b 79030e07b790835ad96de486538811914293881
git cherry-pick 79030e07b790835ad96de4865388119142938814
git push origin 79030e07b790835ad96de486538811914293881

myakove added a commit to myakove/openshift-python-wrapper that referenced this pull request Nov 14, 2022
@myakove
rename all res to self.res (RedHatQE#945)
b84e819 
* rename all res to self.res

* Remove return self.res

* fix self.res calls

* remove return self.res leftover

* remove return self.res leftover
myakove added a commit that referenced this pull request Nov 14, 2022
@myakove
rename all res to self.res (#945) (#969)
8e6f6fc 
* rename all res to self.res

* Remove return self.res

* fix self.res calls

* remove return self.res leftover

* remove return self.res leftover
@cnv-qe-bot cnv-qe-bot mentioned this pull request Nov 14, 2022
Merged
myakove added a commit to myakove/openshift-python-wrapper that referenced this pull request Nov 14, 2022
@myakove
rename all res to self.res (RedHatQE#945) (RedHatQE#969)
bd70644 
* rename all res to self.res

* Remove return self.res

* fix self.res calls

* remove return self.res leftover

* remove return self.res leftover
myakove added a commit that referenced this pull request Dec 1, 2022
@myakove
rename all res to self.res (#971)
b381d89 
* rename all res to self.res (#945) (#969)

* rename all res to self.res

* Remove return self.res

* fix self.res calls

* remove return self.res leftover

* remove return self.res leftover

* remove VirtualMachineExport
@vsibirsk vsibirsk mentioned this pull request Dec 5, 2022
Merged
myakove added a commit that referenced this pull request Aug 11, 2025
@myakove
rename all res to self.res (#945)
574bc21 
* rename all res to self.res

* Remove return self.res

* fix self.res calls

* remove return self.res leftover

* remove return self.res leftover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnetser rnetser rnetser approved these changes

Assignees

@myakove myakove

Labels

Approved-by-rnetser branch-main size/XXL verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myakove @cnv-qe-bot @rnetser