Node Health Check was incorrectly mentioned as namespace dependent in documentation. #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… documentation. Signed-off-by: Geetika Kapoor <gkapoor@redhat.com>
rnetser
approved these changes
Nov 9, 2022
Contributor
Author
|
!verified |
myakove
approved these changes
Nov 9, 2022
Contributor
Author
|
!verified |
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
!verified (rebase only) |
Collaborator
|
!verified |
geetikakay
added a commit
to geetikakay/openshift-python-wrapper
that referenced
this pull request
Nov 10, 2022
… documentation. (RedHatQE#960) Signed-off-by: Geetika Kapoor <gkapoor@redhat.com> Signed-off-by: Geetika Kapoor <gkapoor@redhat.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
rnetser
pushed a commit
that referenced
this pull request
Nov 14, 2022
… documentation. (#960) (#968) Signed-off-by: Geetika Kapoor <gkapoor@redhat.com> Signed-off-by: Geetika Kapoor <gkapoor@redhat.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com> Signed-off-by: Geetika Kapoor <gkapoor@redhat.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
myakove
added a commit
that referenced
this pull request
Aug 11, 2025
… documentation. (#960) Signed-off-by: Geetika Kapoor <gkapoor@redhat.com> Signed-off-by: Geetika Kapoor <gkapoor@redhat.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Geetika Kapoor gkapoor@redhat.com
Short description:
This PR is to fix node health check and removing it's dependency from namespace. There is a documentation bug to fix it from openshift documentation.
Refer : https://issues.redhat.com/browse/TELCODOCS-1029
More details:
What this PR does / why we need it:
When node health check operator is installed it installs Nodehealthcheck and self-node-remediation. Out of which nodehealthcheck is cluster scoped and self-node-remediation is namespaced scope but documentation mentioned both as namespaced scope.
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug: