Skip to content

Conversation

@sbulage
Copy link
Contributor

@sbulage sbulage commented Nov 29, 2022

Add MetalLB Resources into ocp_wrapper.

Short description: In this PR adding MetalLB, IPAddressPool and L2Advertisement CR"s.
More details: For on-premises cluster, MetalLB will play role of managing LoadBalancer.
What this PR does / why we need it: In order to check the compatibility of MetalLB and it's resources with the Bare metal clusters. We require these resources to be added in this repository.

Signed-off-by: Satyajit Bulage sbulage@redhat.com

@cnv-qe-bot
Copy link

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR.

Available user actions:

  • To mark PR as verified add !verified to a PR comment, to un-verify add !-verified to a PR comment.
    Verified label removed on each new commit push.
  • To cherry pick a merged PR add !cherry-pick <target branch to cherry-pick to> to a PR comment.

@myakove
Copy link
Collaborator

myakove commented Nov 30, 2022

Please follow https://github.com/RedHatQE/openshift-python-wrapper/blob/main/CONTRIBUTING.md

@sarahbx
Copy link
Contributor

sarahbx commented Nov 30, 2022

Hi @sbulage, the filename should match the resource. eg: IPAddressPool should be ip_address_pool.py

@sbulage
Copy link
Contributor Author

sbulage commented Nov 30, 2022

Hi @sbulage, the filename should match the resource. eg: IPAddressPool should be ip_address_pool.py

I know that but wanted to highlight the resource with it's parent. To avoid the confusion. But I can change it if it is not the case.

@sbulage
Copy link
Contributor Author

sbulage commented Dec 1, 2022

/add rnetser

@sbulage
Copy link
Contributor Author

sbulage commented Dec 1, 2022

!verified

@sbulage
Copy link
Contributor Author

sbulage commented Dec 5, 2022

!verified

@sbulage
Copy link
Contributor Author

sbulage commented Dec 5, 2022

!verified

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sbulage
Copy link
Contributor Author

sbulage commented Dec 13, 2022

> /Users/sbulage/cnv/cnv_gerrit/cnv-tests/tests/network/metallb/conftest.py(38)metallb_ip_address_pool()
-> ip_addr_pool = cluster_resource(IPAddressPool)(
(Pdb) ip_add_wrong = cluster_resource(IPAddressPool)(name="IP without address", namespace='metallb-system')
2022-12-13T19:35:33.116031 ocp_resources.resource INFO kind: IPAddressPool api version: metallb.io/v1beta1
(Pdb) ip_add_wrong.deploy()
*** ValueError: Either required parameter is missing 'addresses' or provide yaml_file.

@sbulage
Copy link
Contributor Author

sbulage commented Dec 13, 2022

!verified

@rnetser rnetser merged commit f640185 into RedHatQE:main Dec 14, 2022
@sbulage sbulage deleted the add_metallb branch December 15, 2022 05:58
@sbulage
Copy link
Contributor Author

sbulage commented Dec 20, 2022

!cherry-pick v4.12

cnv-qe-bot pushed a commit that referenced this pull request Dec 20, 2022
Signed-off-by: Satyajit Bulage <sbulage@redhat.com>

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
@sbulage sbulage restored the add_metallb branch December 20, 2022 12:52
@myakove
Copy link
Collaborator

myakove commented Dec 20, 2022

!cherry-pick v4.12

@cnv-qe-bot
Copy link

Manual cherry-pick is needed
Cherry pick failed for f640185 to v4.12:
To https://github.com/RedHatQE/openshift-python-wrapper.git
! [rejected] auto-cherry-pick-add_metallb -> auto-cherry-pick-add_metallb (non-fast-forward)
error: failed to push some refs to 'https://github.com/RedHatQE/openshift-python-wrapper.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

To cherry-pick run:

git checkout v4.12
git checkout -b f6401855807799b7b45f1078792b705c722edd4
git cherry-pick f6401855807799b7b45f1078792b705c722edd4c
git push origin f6401855807799b7b45f1078792b705c722edd4

@cnv-qe-bot
Copy link

Manual cherry-pick is needed
Cherry pick failed for f640185 to auto-cherry-pick-add_metallb:
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

To cherry-pick run:

git checkout auto-cherry-pick-add_metallb
git checkout -b f6401855807799b7b45f1078792b705c722edd4
git cherry-pick f6401855807799b7b45f1078792b705c722edd4c
git push origin f6401855807799b7b45f1078792b705c722edd4

myakove pushed a commit to myakove/openshift-python-wrapper that referenced this pull request Dec 20, 2022
Signed-off-by: Satyajit Bulage <sbulage@redhat.com>

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
myakove added a commit that referenced this pull request Dec 20, 2022
Signed-off-by: Satyajit Bulage <sbulage@redhat.com>

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
Co-authored-by: Satyajit Bulage <sbulage@redhat.com>
@sbulage sbulage deleted the add_metallb branch December 20, 2022 13:12
myakove pushed a commit that referenced this pull request Aug 11, 2025
Signed-off-by: Satyajit Bulage <sbulage@redhat.com>

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants