add retry on exception and timeout_seconds for get call #990

dbasunag · 2022-11-30T02:00:32Z

Short description:

rpc error should be retried as during some operations, they are common. However they recoverable.
We need to add a timeout_seconds for regular get calls, as sometimes, we can have hung call.

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

Bug:

cnv-qe-bot · 2022-11-30T02:00:40Z

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR.

Available user actions:

To mark PR as verified add !verified to a PR comment, to un-verify add !-verified to a PR comment.
Verified label removed on each new commit push.
To cherry pick a merged PR add !cherry-pick <target branch to cherry-pick to> to a PR comment.

ocp_resources/resource.py

dbasunag · 2022-12-01T20:38:23Z

@rnetser when I re-requested review from @myakove , I see it removed you as reviewer. I have no idea why and how it happened. Can you please add yourself as a reviewer, as I would prefer to have both your review?

rnetser

Please fix ci :)

…per into add_retry

dbasunag · 2022-12-05T16:23:17Z

!verified

myakove · 2022-12-12T08:16:05Z

!verified

sonarqubecloud · 2022-12-12T08:16:42Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

myakove · 2022-12-12T08:18:13Z

!cherry-pick v4.12

* add retry on exception and timeout_seconds for get call * add retry on exception and timeout_seconds for get call * fix CI issue * fix CI error * add docstring * Update ocp_resources/resource.py Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> * undo the last changes * undo the changes * add timeout_seconds to class attribute Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

cnv-qe-bot · 2022-12-12T08:18:21Z

Cherry-picked PR add retry on exception and timeout_seconds for get call into v4.12

* add retry on exception and timeout_seconds for get call * add retry on exception and timeout_seconds for get call * fix CI issue * fix CI error * add docstring * Update ocp_resources/resource.py Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> * undo the last changes * undo the changes * add timeout_seconds to class attribute Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

…for get call (#1014) * add retry on exception and timeout_seconds for get call (#990) * add retry on exception and timeout_seconds for get call * add retry on exception and timeout_seconds for get call * fix CI issue * fix CI error * add docstring * Update ocp_resources/resource.py Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> * undo the last changes * undo the changes * add timeout_seconds to class attribute Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com> * Add TIMEOUT_1MINUTE constant Co-authored-by: Debarati Basu-Nag <dbasunag@redhat.com> Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

dbasunag · 2022-12-13T15:54:29Z

!cherry-pick v4.11

* add retry on exception and timeout_seconds for get call * add retry on exception and timeout_seconds for get call * fix CI issue * fix CI error * add docstring * Update ocp_resources/resource.py Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> * undo the last changes * undo the changes * add timeout_seconds to class attribute Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

cnv-qe-bot · 2022-12-13T15:54:38Z

Cherry-picked PR add retry on exception and timeout_seconds for get call into v4.11

* add retry on exception and timeout_seconds for get call * add retry on exception and timeout_seconds for get call * fix CI issue * fix CI error * add docstring * Update ocp_resources/resource.py Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> * undo the last changes * undo the changes * add timeout_seconds to class attribute Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

* add retry on exception and timeout_seconds for get call (#990) * add retry on exception and timeout_seconds for get call * add retry on exception and timeout_seconds for get call * fix CI issue * fix CI error * add docstring * Update ocp_resources/resource.py Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> * undo the last changes * undo the changes * add timeout_seconds to class attribute Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com> * Add constant TIMEOUT_1MINUTE Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

…atQE#1023) * add retry on exception and timeout_seconds for get call (RedHatQE#990) * add retry on exception and timeout_seconds for get call * add retry on exception and timeout_seconds for get call * fix CI issue * fix CI error * add docstring * Update ocp_resources/resource.py Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> * undo the last changes * undo the changes * add timeout_seconds to class attribute Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com> * Add constant TIMEOUT_1MINUTE Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

… (#1029) * add retry on exception and timeout_seconds for get call (#990) * add retry on exception and timeout_seconds for get call * add retry on exception and timeout_seconds for get call * fix CI issue * fix CI error * add docstring * Update ocp_resources/resource.py Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> * undo the last changes * undo the changes * add timeout_seconds to class attribute Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com> * Add constant TIMEOUT_1MINUTE Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com> Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

* add retry on exception and timeout_seconds for get call * add retry on exception and timeout_seconds for get call * fix CI issue * fix CI error * add docstring * Update ocp_resources/resource.py Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> * undo the last changes * undo the changes * add timeout_seconds to class attribute Co-authored-by: Ruth Netser <54615090+rnetser@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

add retry on exception and timeout_seconds for get call

16439d0

cnv-qe-bot added size/XS branch-main labels Nov 30, 2022

cnv-qe-bot assigned dbasunag Nov 30, 2022

cnv-qe-bot requested review from myakove and rnetser November 30, 2022 02:00

cnv-qe-bot mentioned this pull request Nov 30, 2022

add retry on exception and timeout_seconds for get call - 990 #991

Closed

myakove requested changes Nov 30, 2022

View reviewed changes

ocp_resources/resource.py Outdated Show resolved Hide resolved

cnv-qe-bot added the Changes_Requested-by-myakove label Nov 30, 2022

Merge branch 'main' into add_retry

d2b684c

cnv-qe-bot removed the Changes_Requested-by-myakove label Dec 1, 2022

dbasunag requested review from myakove and removed request for rnetser December 1, 2022 20:36

rnetser self-requested a review December 5, 2022 06:29

rnetser previously approved these changes Dec 5, 2022

View reviewed changes

cnv-qe-bot added the Approved-by-rnetser label Dec 5, 2022

rnetser reviewed Dec 5, 2022

View reviewed changes

cnv-qe-bot added Commented-by-rnetser and removed Approved-by-rnetser labels Dec 5, 2022

dbasunag added 3 commits December 5, 2022 07:19

add retry on exception and timeout_seconds for get call

1e7341e

fix CI issue

8e0f19c

Merge branch 'RedHatQE:main' into add_retry

e3a2350

cnv-qe-bot removed the Commented-by-rnetser label Dec 5, 2022

dbasunag added 2 commits December 5, 2022 07:22

Merge branch 'add_retry' of github.com:dbasunag/openshift-python-wrap…

78cf83a

…per into add_retry

fix CI error

7efa168

dbasunag dismissed rnetser’s stale review via 7efa168 December 5, 2022 12:26

cnv-qe-bot added the verified label Dec 5, 2022

cnv-qe-bot added the Approved-by-rnetser label Dec 10, 2022

myakove approved these changes Dec 12, 2022

View reviewed changes

cnv-qe-bot added the Approved-by-myakove label Dec 12, 2022

Merge branch 'main' into add_retry

e9b8f70

cnv-qe-bot removed Approved-by-myakove Approved-by-rnetser verified labels Dec 12, 2022

cnv-qe-bot added the verified label Dec 12, 2022

myakove approved these changes Dec 12, 2022

View reviewed changes

cnv-qe-bot added the Approved-by-myakove label Dec 12, 2022

myakove merged commit 1ac36f0 into RedHatQE:main Dec 12, 2022

cnv-qe-bot mentioned this pull request Dec 12, 2022

auto-cherry-pick: [v4.12] add retry on exception and timeout_seconds for get call #1014

Merged

cnv-qe-bot mentioned this pull request Dec 13, 2022

auto-cherry-pick: [v4.11] add retry on exception and timeout_seconds for get call #1019

Closed

dbasunag mentioned this pull request Dec 14, 2022

[v4.10] add retry on exception and timeout_seconds for get call (#1023) #1029

Merged

dbasunag deleted the add_retry branch February 25, 2025 18:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add retry on exception and timeout_seconds for get call #990

add retry on exception and timeout_seconds for get call #990

Uh oh!

dbasunag commented Nov 30, 2022 •

edited by myakove

Loading

Uh oh!

cnv-qe-bot commented Nov 30, 2022

Uh oh!

Uh oh!

dbasunag commented Dec 1, 2022

Uh oh!

rnetser left a comment

Uh oh!

dbasunag commented Dec 5, 2022

Uh oh!

myakove commented Dec 12, 2022

Uh oh!

sonarqubecloud bot commented Dec 12, 2022

Uh oh!

myakove commented Dec 12, 2022

Uh oh!

cnv-qe-bot commented Dec 12, 2022

Uh oh!

dbasunag commented Dec 13, 2022

Uh oh!

cnv-qe-bot commented Dec 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

add retry on exception and timeout_seconds for get call #990

add retry on exception and timeout_seconds for get call #990

Uh oh!

Conversation

dbasunag commented Nov 30, 2022 • edited by myakove Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

Bug:

Uh oh!

cnv-qe-bot commented Nov 30, 2022

Uh oh!

Uh oh!

dbasunag commented Dec 1, 2022

Uh oh!

rnetser left a comment

Choose a reason for hiding this comment

Uh oh!

dbasunag commented Dec 5, 2022

Uh oh!

myakove commented Dec 12, 2022

Uh oh!

sonarqubecloud bot commented Dec 12, 2022

Uh oh!

myakove commented Dec 12, 2022

Uh oh!

cnv-qe-bot commented Dec 12, 2022

Uh oh!

dbasunag commented Dec 13, 2022

Uh oh!

cnv-qe-bot commented Dec 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dbasunag commented Nov 30, 2022 •

edited by myakove

Loading