Add functionality to role.py and refactor cluster_role.py #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
!verified |
myakove
requested changes
Nov 30, 2022
Collaborator
myakove
left a comment
myakove
left a comment
There was a problem hiding this comment.
Rename the PR title, it's wrong and do not describe the PR content.
rnetser
requested changes
Dec 1, 2022
Collaborator
rnetser
left a comment
rnetser
left a comment
There was a problem hiding this comment.
Please update the description and title - to match what is done is the RP
Anatw
force-pushed
the
add_resouce_content
branch
from
0b9f219 to
6d8546e
Compare
Contributor
Author
|
!verified |
rnetser
requested changes
Dec 5, 2022
Collaborator
rnetser
left a comment
rnetser
left a comment
There was a problem hiding this comment.
Please update the PR title to match the code
myakove
requested changes
Dec 5, 2022
Collaborator
myakove
left a comment
myakove
left a comment
There was a problem hiding this comment.
The PR title do not reflect the PR changes.
Anatw
force-pushed
the
add_resouce_content
branch
from
6d8546e to
ceff7c7
Compare
Anatw
force-pushed
the
add_resouce_content
branch
from
ceff7c7 to
1fdf52c
Compare
Anatw
force-pushed
the
add_resouce_content
branch
2 times, most recently
from
567f75e to
0dd3437
Compare
myakove
requested changes
Dec 15, 2022
Anatw
force-pushed
the
add_resouce_content
branch
from
834d961 to
1ba6505
Compare
Contributor
Author
|
!verified |
- Refactor cluster_role.py. - Add common code to utils.py. - Add an example to the README.md on how to add multiple rules to a single Role/ClusterRole.
Anatw
force-pushed
the
add_resouce_content
branch
from
1ba6505 to
c2070f7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
!verified |
myakove
approved these changes
Dec 19, 2022
rnetser
approved these changes
Dec 19, 2022
Contributor
Author
|
!cherry-pick v4.12 |
cnv-qe-bot
pushed a commit
that referenced
this pull request
Jan 15, 2023
- Refactor cluster_role.py. - Add common code to utils.py. - Add an example to the README.md on how to add multiple rules to a single Role/ClusterRole.
|
Cherry-picked PR Add functionality to role.py and refactor cluster_role.py into v4.12 |
Anatw
added a commit
to Anatw/openshift-python-wrapper
that referenced
this pull request
Feb 19, 2023
- Refactor cluster_role.py. - Add common code to utils.py. - Add an example to the README.md on how to add multiple rules to a single Role/ClusterRole. Signed-off-by: Anat Wax <awax@redhat.com>
Anatw
added a commit
to Anatw/openshift-python-wrapper
that referenced
this pull request
Feb 21, 2023
- Refactor cluster_role.py. - Add common code to utils.py. - Add an example to the README.md on how to add multiple rules to a single Role/ClusterRole.
Anatw
added a commit
to Anatw/openshift-python-wrapper
that referenced
this pull request
Feb 21, 2023
- Refactor cluster_role.py. - Add common code to utils.py. - Add an example to the README.md on how to add multiple rules to a single Role/ClusterRole.
rnetser
pushed a commit
that referenced
this pull request
Feb 21, 2023
- Refactor cluster_role.py. - Add common code to utils.py. - Add an example to the README.md on how to add multiple rules to a single Role/ClusterRole. Co-authored-by: Anat Wax <46938838+Anatw@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
myakove
pushed a commit
that referenced
this pull request
Aug 11, 2025
- Refactor cluster_role.py. - Add common code to utils.py. - Add an example to the README.md on how to add multiple rules to a single Role/ClusterRole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug: