Move to UV #128
Move to UV #128
Conversation
WalkthroughThis pull request introduces significant changes to the project configuration, transitioning from Poetry to Hatch as the build system. The modifications span across multiple configuration files including Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Report bugs in Issues The following are automatically added:
Available user actions:
Supported /retest check runs
Supported labels
|
|
/verified |
|
/verified |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
.release-it.json (1)
45-46: Consider additional UV sync parameters.The
uv synccommand might benefit from additional parameters to ensure proper dependency synchronization.- "after:bump": "uv sync" + "after:bump": "uv sync --python 3.9"pyproject.toml (2)
9-9: Consider relaxing Python version constraint.The current constraint
~=3.9might be too restrictive. Consider using>=3.9if there's no specific reason to pin to 3.9.x series.-requires-python = "~=3.9" +requires-python = ">=3.9"
42-46: Consider additional build configuration.The Hatch build targets might benefit from additional configuration options such as:
- Excluding test files from wheel
- Adding package data configurations
- Specifying Python tag requirements
[tool.hatch.build.targets.wheel] include = ["simple_logger"] +exclude = ["simple_logger/tests/*"] +python-tag = "py39"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
poetry.lockis excluded by!**/*.lockuv.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
.release-it.json(2 hunks)pyproject.toml(2 hunks)tox.ini(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: python-module-install
- GitHub Check: tox
🔇 Additional comments (4)
tox.ini (1)
11-11: Verify test command configuration.The current command might need additional arguments for proper test execution. Consider adding test coverage and verbosity flags.
- uv run pytest simple_logger/tests + uv run pytest simple_logger/tests -v --cov=simple_logger --cov-report=term-missing.release-it.json (1)
41-42: Verify version path configuration.The version path
project.versionin the bumper configuration needs to match the structure in pyproject.toml. Please verify this matches the expected TOML path.✅ Verification successful
Version path configuration is correct ✅
The version path
project.versionin the bumper configuration matches the structure in pyproject.toml, where the version is defined under the[project]section.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the version path exists in pyproject.toml cat pyproject.toml | python3 -c " import sys, tomli try: data = tomli.loads(sys.stdin.read()) print(f'Version found: {data[\"project\"][\"version\"]}') except (KeyError, tomli.TOMLDecodeError) as e: print(f'Error: {e}') sys.exit(1) "Length of output: 378
Script:
#!/bin/bash # Check if pyproject.toml exists and search for version configuration if [ -f pyproject.toml ]; then echo "Content of pyproject.toml:" cat pyproject.toml echo -e "\nSearching for version configuration:" grep -A 2 -B 2 "version" pyproject.toml else echo "pyproject.toml not found" fiLength of output: 2021
pyproject.toml (2)
67-68: LGTM! Build system configuration is correct.The build system configuration properly specifies hatchling as the build backend.
27-29: Review dependency version constraints.Some dependency versions might need adjustment:
- pytest 8.0.0 is very recent and might have stability issues
- Consider adding upper bounds for ipython to ensure compatibility
Summary by CodeRabbit
Release Notes
uvfor dependency synchronizationhatchling