Skip to content

Changed return type from parse_json_response#11

Merged
myakove merged 7 commits into
RedHatQE:mainfrom
oharan2:response_fix
Jun 8, 2023
Merged

Changed return type from parse_json_response#11
myakove merged 7 commits into
RedHatQE:mainfrom
oharan2:response_fix

Conversation

@oharan2

@oharan2 oharan2 commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@redhat-qe-bot

Copy link
Copy Markdown
Collaborator

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
    *Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Support only merged PRs
  • To re-run tox comment /tox in the PR.
  • To re-run build-container command /build-container in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To re-run python-module-install command /python-module-install in the PR.
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • target-version-

@myakove

myakove commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

/lgtm

@myakove

myakove commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

/hold

@myakove

myakove commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

Need to rector the usage where needed

rnetser
rnetser previously approved these changes Jun 1, 2023
@oharan2

oharan2 commented Jun 5, 2023

Copy link
Copy Markdown
Contributor Author

/verified

Comment thread rosa/cli.py Outdated
Comment thread rosa/cli.py Outdated
@oharan2

oharan2 commented Jun 5, 2023

Copy link
Copy Markdown
Contributor Author

/verified

Comment thread rosa/cli.py Outdated
Comment thread rosa/cli.py
@oharan2

oharan2 commented Jun 6, 2023

Copy link
Copy Markdown
Contributor Author

/verified

@oharan2

oharan2 commented Jun 7, 2023

Copy link
Copy Markdown
Contributor Author

Need to rector the usage where needed

Resolved in #160

@sonarqubecloud

sonarqubecloud Bot commented Jun 7, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oharan2

oharan2 commented Jun 7, 2023

Copy link
Copy Markdown
Contributor Author

/verified

@myakove

myakove commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

/hold cancel

@redhat-qe-bot redhat-qe-bot removed the hold label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants