Skip to content

Set aws credentials os env before change home dir#36

Merged
myakove merged 4 commits into
mainfrom
aws_credentials
Jun 27, 2023
Merged

Set aws credentials os env before change home dir#36
myakove merged 4 commits into
mainfrom
aws_credentials

Conversation

@myakove

@myakove myakove commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@redhat-qe-bot

Copy link
Copy Markdown
Collaborator

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Support only merged PRs
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • target-branch-

@myakove

myakove commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator Author

/verified

Comment thread rosa/cli.py Outdated
return execute_command(command=command)


def aws_credentials():

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for how it's implemented here, do you think we should move it to cloud_tools (for general use) and call it something like set_aws_credentials ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myakove

myakove commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator Author

depends on RedHatQE/cloud-tools#80

@myakove

myakove commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator Author

/verified

@myakove

myakove commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator Author

/hold

@myakove

myakove commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator Author

/hold cancel

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myakove

myakove commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator Author

/verified

@myakove myakove merged commit a5492bc into main Jun 27, 2023
@myakove myakove deleted the aws_credentials branch June 27, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants