[1LP][RFR] Remove need to pin python-novaclient with s/HTTPClient/SessionClient#246
Merged
Conversation
mshriver
approved these changes
Apr 16, 2018
mshriver
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good, pending testing results for version conflicts.
Contributor
Author
|
Testing locally using test_instance_power_control with RHOS provider in integration_tests (the fixture in there relies on create_on_provider which deploys a VM template, so this should exercise 'novaclient' decently). Looks good so far. |
jamesooden
approved these changes
Apr 16, 2018
Collaborator
|
And as I click comment the page updates with new commits, James's review, and passing checks. thx GH. |
Contributor
Author
mshriver
approved these changes
Apr 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears the only reason python-novaclient was pinned was due to the library's removal of 'HTTPClient' (and apparently SessionClient provides the same interface). We had already moved to 'SessionClient' in openstack.py, but had not done it for openstack_infra.py -- the code blocks for this section in both files is pretty much identical.