Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69bf2f719f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const LANE_W = 230; | ||
| const LANE_GAP = 40; | ||
| const NODE_W = 200; | ||
| const NODE_H = 100; |
There was a problem hiding this comment.
The new fixed NODE_H = 100 makes node sizing independent of content even though rendering can include up to two title lines, two subtitle lines, and a file reference line. For nodes where both title and subtitle wrap and fileRef is present, the subtitle and ref text baselines collide near the bottom of the box, so labels overlap or clip and become unreadable; this is a regression from the previous text-height-based sizing.
Useful? React with 👍 / 👎.
| if (rowDiff <= 1) { | ||
| // Adjacent rows: straight vertical line | ||
| d = "M " + x1 + "," + y1 + " L " + x2 + "," + y2; | ||
| labelX = x1 + from.width / 2 + 14; |
There was a problem hiding this comment.
For same-lane edges, labelX now adds from.width / 2 on top of the center point, which places start-anchored labels at the lane’s extreme right edge. In the rightmost lane this leaves only a few pixels before the SVG boundary, so typical labels (more than a few characters) extend beyond the viewBox and are visibly cut off.
Useful? React with 👍 / 👎.
2 participants
No description provided.