Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

Conversation

@gaecoli
Copy link
Member

@gaecoli gaecoli commented May 12, 2023

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

image

For the dropdown list, there should be an alias note for everyone to check.

@gaecoli
Copy link
Member Author

gaecoli commented May 12, 2023

image

image

@gaecoli
Copy link
Member Author

gaecoli commented May 12, 2023

@justinclift I will merge it. Do you have any problems?

@gaecoli gaecoli merged commit 0e7fbde into RedashCommunity:master May 12, 2023
@justinclift
Copy link
Member

Go for it. 😄

The upcoming 10.x images we create should be based on a release/10.x or similar branch anyway, which we can look into later.

@gaecoli
Copy link
Member Author

gaecoli commented May 12, 2023

Go for it. 😄

The upcoming 10.x images we create should be based on a release/10.x or similar branch anyway, which we can look into later.

ok

@justinclift
Copy link
Member

justinclift commented May 12, 2023

Hmmm, I wonder if any of the people wanting to help out with the new Redash Community - but who haven't joined yet - are good at writing blog posts / docs / similar?

If there are, we could see if they want to create info (for end users) about the user interface changes being made.

Something like the lines of:

2023.05.12 This week in Redash

* @gaecoli enhanced `enum` parameters, so [...]
  [ screenshots ]
  Some description of the change goes here (etc)

* [ other changes ]

That would probably make things easier for people to understand, and the same screenshots / text could be assembled into more formal documentation at some point.


Heh Heh Heh

I'll move this idea from here to a Discussion somewhere. Need to go shopping first... 😄

@gaecoli
Copy link
Member Author

gaecoli commented May 13, 2023

Hmmm, I wonder if any of the people wanting to help out with the new Redash Community - but who haven't joined yet - are good at writing blog posts / docs / similar?

If there are, we could see if they want to create info (for end users) about the user interface changes being made.

Something like the lines of:

2023.05.12 This week in Redash

* @gaecoli enhanced `enum` parameters, so [...]
  [ screenshots ]
  Some description of the change goes here (etc)

* [ other changes ]

That would probably make things easier for people to understand, and the same screenshots / text could be assembled into more formal documentation at some point.

Heh Heh Heh

I'll move this idea from here to a Discussion somewhere. Need to go shopping first... 😄

I think it's a good idea.

@justinclift
Copy link
Member

Good reminder. Just created discussions about it here, and in the original Redash repo. Lets see how it goes. 😄

@justinclift justinclift added the documentation Improvements or additions to documentation label May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants