Let fork GC call vecsim tiered index GC#3657
Merged
Conversation
DvirDukhan
previously approved these changes
Jul 13, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3657 +/- ##
==========================================
+ Coverage 82.51% 82.53% +0.02%
==========================================
Files 192 192
Lines 32233 32255 +22
==========================================
+ Hits 26597 26622 +25
+ Misses 5636 5633 -3
☔ View full report in Codecov by Sentry. |
DvirDukhan
approved these changes
Jul 13, 2023
alonre24
added a commit
that referenced
this pull request
Jul 16, 2023
alonre24
added a commit
that referenced
this pull request
Jul 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let fork GC call a new API in VecSim lib that allows calling the GC of all tiered indexes that are associated with some field in the index schema.