fix: Don't check license headers in the target directory#8226
Merged
LukeMathWalker merged 1 commit intomasterfrom Jan 30, 2026
Merged
fix: Don't check license headers in the target directory#8226LukeMathWalker merged 1 commit intomasterfrom
LukeMathWalker merged 1 commit intomasterfrom
Conversation
memark
reviewed
Jan 30, 2026
| if path.file_name().and_then(|s| s.to_str()) == Some("thin_vec") { | ||
| let filename = path.file_name().and_then(|s| s.to_str()); | ||
| if filename == Some("thin_vec") { | ||
| // That crate is under a different license, since it's a fork. |
Collaborator
There was a problem hiding this comment.
This is a good comment, maybe put part of it in the printed message instead?
memark
approved these changes
Jan 30, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8226 +/- ##
==========================================
- Coverage 83.01% 82.98% -0.03%
==========================================
Files 383 383
Lines 56330 56334 +4
Branches 15161 15165 +4
==========================================
- Hits 46760 46750 -10
- Misses 9416 9430 +14
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kei-nan
pushed a commit
that referenced
this pull request
Feb 3, 2026
pull bot
pushed a commit
to Mu-L/RediSearch
that referenced
this pull request
Feb 3, 2026
* initial commit (cherry picked from commit ab63a17) * fix api * some redesign of how search results are maintained * expose link_static_lib to allow disk to use it * add a way to control if async api will be used * fail debug command if async io is not supported * separate functions * update debug test and command * simplify some of the flow * put async after regular version * use double buffering * dynamically increase index result buffer * use double linked list to manage and track reads * code review fixes * change disk api to simplify passing and cleaning up dmd pointer * code review fixes * simplify error handling api * fix compilation * few fixes * fix cursor code review comments * minor fixes * code review fixes * remove check * pass right allocate callback * moved async state to its own file, added state machine like tests * fix cursor's code review comment * code review fix * address code review comments * fix code review comments * small fix * fix code review comments * minor refactoring to address code review comment * cide review fixes * code review comment * address code review comments * use case insensitive comparison * update header * [MOD-13616] Use new strict FAIL timeout mechanism in FT.SEARCH coordinator (RediSearch#8191) * draft * Use abort on error path * use free priv data * test * avoid leak * skip SA * Cursor comments * profile reply with unblock * remove assert * test profile * Cleanup for PR * move postProcess to before unblocking the client * test timeout before fanout * remove double postProcess * review Phase1 * Phase 2 * fast check resp3 * fix resp3 * move clear errror * Fix error pass * Move error handling to MRCTX * check cmd before free * fix * Better assert and comment * Change check * Assign Query error if not assigned * MRcommand free safe * MOD-13701: Update deepdiff dependency version in pyproject.toml to >=8.6.1 (RediSearch#8212) * Update deepdiff dependency version in pyproject.toml to >=8.6.1 * Update dependency versions for deepdiff and orderly-set in uv.lock and pyproject.toml * Update deepdiff and orderly-set versions in uv.lock and pyproject.toml to latest releases * Pin deepdiff version to 8.6.1 in uv.lock and pyproject.toml for consistency * ci: update redisbench-admin (RediSearch#8213) * update to make sure load is recycled * bump redisbench-admin version * benchmark reqs update * update ver redisbench-admin * bump ver * update redisbench-admin * remove dataset name from load benchmark * Update tests/benchmarks/search-msmarco-6M-documents-load.yml * fix: Don't check license headers in the target directory (RediSearch#8226) * MOD-13602 Add queue time tracking to FT.PROFILE (RediSearch#8210) * Add validation tests for FT.PROFILE queue time bug Add design document and validation tests that confirm the bug exists: - testParsingTimeIncludesWorkersQueueTime_BUG: Confirms workers queue wait time is incorrectly included in 'Parsing time' (bug) - testParsingTimeDoesNotIncludeCoordQueueTime: Confirms coordinator queue time is correctly separate from shard's Parsing time Both tests pass, confirming the bug exists as described in the design doc. * Implement Part 1: Workers queue time in FT.PROFILE - Add profileQueueTime field to AREQ struct in aggregate.h - Capture queue time at start of AREQ_Execute_Callback() in aggregate_exec.c - Queue time = elapsed time since initClock was set before enqueueing - Reset initClock after capturing queue time for accurate parsing time - Print 'Workers queue time' in profile output in profile.c - Add testWorkersQueueTimeInProfile test to verify the fix - Mark testParsingTimeIncludesWorkersQueueTime_BUG as skipped (bug is fixed) This fixes the bug where FT.PROFILE's 'Parsing time' incorrectly included time spent waiting in the workers thread pool queue. * Add coordinator queue time tracking to FT.PROFILE Track time spent waiting in the coordinator thread pool queue and report it as 'Coordinator queue time' in FT.PROFILE output. Changes: - Add coordQueueTime field to ConcurrentSearchHandlerCtx struct - Add coordQueueTime field to searchRequestCtx struct - Calculate queue time in DistSearchCommandHandler and DEBUG_DistSearchCommandHandler - Copy queue time to searchRequestCtx in FlatSearchCommandHandler - Print 'Coordinator queue time' in profileSearchReplyCoordinator * Add test for coordinator queue time in FT.PROFILE Add testCoordinatorQueueTimeInProfile to verify that coordinator queue time is correctly captured in cluster mode when the coordinator thread pool is paused. * Remove design document (intermediate artifact) * Fix tests for new Workers queue time and Coordinator queue time fields * Address Cursor Bugbot review: remove obsolete test and unused env parameters * Add AGENTS.local.md to .gitignore * Fix test expectations for new Workers queue time field in FT.PROFILE output * Remove redundant comments from queue time tracking code * Fix test_RED_86036 index after adding Workers queue time to FT.PROFILE * Fix dead code issue * Revert unrelated changes to AGENTS.md and .gitignore * CR- larger debug pauses, clock only on profile and different output order * CR- dont init clock * MOD-13357: Add disk expiration support in OSS side (RediSearch#8218) Add disk expiration support in OSS side * try and align with master * add assert --------- Co-authored-by: lerman25 <58445352+lerman25@users.noreply.github.com> Co-authored-by: Itzikvaknin <82322982+Itzikvaknin@users.noreply.github.com> Co-authored-by: Joan Fontanals <jfontanalsmartinez@gmail.com> Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com> Co-authored-by: ofiryanai <ofiryanai1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Don't touch, in particular, generated files in the OUT directory for build scripts.
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable
Release Notes
If a release note is required (bug fix / new feature / enhancement), describe the user impact of this PR in the title.
Note
Low Risk
Low risk: a small change to the license-header linter’s directory traversal that only avoids processing generated build output, reducing false positives and unintended edits.
Overview
Prevents the Rust license header linter from scanning or modifying generated files by skipping the
targetdirectory during recursive traversal.Keeps existing special-cases (e.g.,
thin_vec,controlled_cursor.rs) while slightly refactoring directory-name handling.Written by Cursor Bugbot for commit 01e4bea. This will update automatically on new commits. Configure here.