Skip to content

Ensure accurate backgroundIndexing status in debugInfo #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2025
Merged

Ensure accurate backgroundIndexing status in debugInfo #811

merged 1 commit into from
Oct 26, 2025

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Oct 26, 2025 •
edited
Loading

  • Lock updateJobMutex when checking backgroundIndexing status in debugInfo
  • Make updateJobMutex mutable to allow locking in const debugInfo() method

@meiravgri
convert updateJobMutex to mutable
2ee755d 
check backgroundIndexing under the lock
@codecov
Copy link

codecov bot commented Oct 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.02%. Comparing base (cea54c9) to head (2ee755d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   96.88%   97.02%   +0.14%     
==========================================
  Files         126      126              
  Lines        7740     7366     -374     
==========================================
- Hits         7499     7147     -352     
+ Misses        241      219      -22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri changed the title convert updateJobMutex to mutable Ensure accurate backgroundIndexing status in debugInfo Oct 26, 2025
@meiravgri meiravgri changed the title Ensure accurate backgroundIndexing status in debugInfo Ensure accurate backgroundIndexing status in debugInfo Oct 26, 2025
@meiravgri meiravgri enabled auto-merge October 26, 2025 15:06
@meiravgri meiravgri added this pull request to the merge queue Oct 26, 2025
Merged via the queue into main with commit 46e69b4 Oct 26, 2025
34 checks passed
@meiravgri meiravgri deleted the meiravg_protect_bg_indexing_info branch October 26, 2025 15:37
@meiravgri
Copy link
Collaborator Author

meiravgri commented Oct 26, 2025

/backport

@github-actions
Copy link

github-actions bot commented Oct 26, 2025

Successfully created backport PR for 8.2:

github-actions bot pushed a commit that referenced this pull request Oct 26, 2025
@meiravgri @github-actions
Ensure accurate backgroundIndexing status in debugInfo (#811)
d61e592 
convert updateJobMutex to mutable

check backgroundIndexing under the lock

(cherry picked from commit 46e69b4)
@github-actions github-actions bot mentioned this pull request Oct 26, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 26, 2025
@github-actions @meiravgri
[8.2] Ensure accurate backgroundIndexing status in debugInfo (#812)
43b2ed7 
Ensure accurate `backgroundIndexing` status in debugInfo (#811)

convert updateJobMutex to mutable

check backgroundIndexing under the lock

(cherry picked from commit 46e69b4)

Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
@meiravgri meiravgri mentioned this pull request Oct 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lerman25 lerman25 lerman25 approved these changes

Assignees

No one assigned

Labels

backport 8.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meiravgri @lerman25