reading indexUpdateScheduled under the lock guard
#813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiravgri
changed the title
indexUpdateScheduled value under the lock guard
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 97.02% 97.02%
=======================================
Files 126 126
Lines 7366 7366
=======================================
Hits 7147 7147
Misses 219 219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meiravgri
changed the title
indexUpdateScheduled value under the lock guardindexUpdateScheduled under the lock guard
lerman25
approved these changes
Oct 27, 2025
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-813-to-8.2 origin/8.2
cd .worktree/backport-813-to-8.2
git switch --create backport-813-to-8.2
git cherry-pick -x 1db4e00eb744900b21d4adf9c8a01ec01fa89a57 |
meiravgri
added a commit
to RediSearch/RediSearch
that referenced
this pull request
Oct 27, 2025
meiravgri
added a commit
that referenced
this pull request
Oct 27, 2025
* reading indexUpdateScheduled under the lock * dont lock twice (cherry picked from commit 1db4e00)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
* reading `indexUpdateScheduled` under the lock guard (#813) * reading indexUpdateScheduled under the lock * dont lock twice (cherry picked from commit 1db4e00) * revert removing addVector test from svs tiered (#814) revert removeing addVector test from svs tiered (cherry picked from commit 3513261) * remove multi
github-merge-queue bot
pushed a commit
to RediSearch/RediSearch
that referenced
this pull request
Nov 5, 2025
* introdcue vecsim_utils and test_vecsim_svs move set_up_database_with_vectors and get_unique_vector from test_shard_k_ratio.py so it can be used by other test files add NO_COMPRESSION to test_svs_vamana_info_with_compression * apply trainingTriggerThreshold default value in vector index params only if quantBits == VecSimSvsQuant_NONE to align with vecsim logic that uses update_threshold for non-compressed indices VecSim_IsLeanVecCompressionType now also checks if isLVQSupported() * fix common and vecsim utils * fix typo * add test_empty_index * change_threads and test_drop_index * implment hybrid query fi test_index_multi_value_json to intialzie svs * fix test * gc test * TO REVERT: VECSIM VERSION! * bumo vecsim * test_hybrid_query_with_text_vamana: no compression test_small_window_size: wrap with try test_drop_index: decrease dim test_drop_index_during_query: skip cluster * skip gc test * revert skip * revert change (?) * revert back disable unit tesdsts * no specific * fix test_hybrid_query_with_text_vamana * revert vec generation * global seed 42 again fix query declaration, run only vecsim svs * return correct field name * 2 * block_size vecs * print vectors * upload vecs * skip ccoed test_small_window_size * fix path * skip coord * increase size * imp queries_sanity for coord fix test_insufficient_docs_per_shard CONSTRUCTION_WINDOW_SIZE = 20 * enable intel CI * no opt * fix comon * fix field name enable CI * enable intel * test_small_window_size :return on creash compare_debug_info_to_ft_info: fix to work, but queries_sanity: fix to use con, queries_sanity empty_index: ready for clustet * BUG FIX FOR SMALL WINDOW: run against vecsim meiravg_svs_crash_fix with intel PUBLIC (no optimization) * return memory checkk * print proc mem * fix memory test flakyness * enable all flow * add svs size debug print * vecsim point to meiravg_protect_bg_indexing_info dix cluster wait to wait_for_background_indexing enable BUILD_INTEL_SVS_OPT * point vecsim to meiravg_protect_bg_indexing_info * adjust change_threadsfor coord take vecsim meiravg_protect_bg_indexing_info_fix * cluster skip change_threads and test_gc skip test_small_window_size until bug is fixed skip test_hybrid_query_with_text_vamana until bug is fixed * cleanup * enable test_create enable for cluster: test_rdb_load_trained_svs_vamana * fix spell * bumo vecsim RedisAI/VectorSimilarity#813 * split queries_sanity * less vectors in test_hybrid_query_with_text_vamana larger batch * disable temp * test_rdb_load_trained_svs_vamana: dim: 4-> 2 num docs: * 2 -> *1.1 data_type: all-> random test_svs_vamana_info dim: 16-> 2 num docs: * 2 -> *1.1 compression_type: all-> with EXTENDED_PYTESTS test_vamana_debug_info_vs_info diim: 4->2 test_memory_info: dim: 10->2 datatype-> random queries_sanity: generate outsize num_docs: * 2-> 1.1 query: num_docs-> 1 test_vamana_debug_info_vs_info: dim 4->2 test_memory_info dim: 10->2 data_type: random test_drop_index_memory dim: 4-> 2 test_gc: dim 128->? 28 * reduce to 300 * fix test_index_multi_value_json for coord remove env arg from test_rdb_load_trained_svs_vamana * wait_for_background_indexing print size in message * fix wait message * more time * increase timeout print all shards info * index_size->index_sizes * align to apply Ishwar fix on top of v0.0.10 in vecsim disable intel opt to run against svs public repo with the fix enable intel flow disable unit tests * remove the skip.... * test_index_multi_value_json increase CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE * use vecsim main * use BUILD_INTEL_SVS_OPT * return test_small_window_size skip * queries_sanity: CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE as number of docs wait_for_background_indexing: print on mac * print with force * prined is_trained arr * fix index_state print * fix test_drop_index_during_query to use svs.... be more verbose in change_threads increasetimeout * wf cleanups * test_drop_index_during_query: check query result wait_for_background_indexing: remove mac print
github-merge-queue bot
pushed a commit
to RediSearch/RediSearch
that referenced
this pull request
Nov 5, 2025
* introdcue vecsim_utils and test_vecsim_svs move set_up_database_with_vectors and get_unique_vector from test_shard_k_ratio.py so it can be used by other test files add NO_COMPRESSION to test_svs_vamana_info_with_compression * apply trainingTriggerThreshold default value in vector index params only if quantBits == VecSimSvsQuant_NONE to align with vecsim logic that uses update_threshold for non-compressed indices VecSim_IsLeanVecCompressionType now also checks if isLVQSupported() * fix common and vecsim utils * fix typo * add test_empty_index * change_threads and test_drop_index * implment hybrid query fi test_index_multi_value_json to intialzie svs * fix test * gc test * TO REVERT: VECSIM VERSION! * bumo vecsim * test_hybrid_query_with_text_vamana: no compression test_small_window_size: wrap with try test_drop_index: decrease dim test_drop_index_during_query: skip cluster * skip gc test * revert skip * revert change (?) * revert back disable unit tesdsts * no specific * fix test_hybrid_query_with_text_vamana * revert vec generation * global seed 42 again fix query declaration, run only vecsim svs * return correct field name * 2 * block_size vecs * print vectors * upload vecs * skip ccoed test_small_window_size * fix path * skip coord * increase size * imp queries_sanity for coord fix test_insufficient_docs_per_shard CONSTRUCTION_WINDOW_SIZE = 20 * enable intel CI * no opt * fix comon * fix field name enable CI * enable intel * test_small_window_size :return on creash compare_debug_info_to_ft_info: fix to work, but queries_sanity: fix to use con, queries_sanity empty_index: ready for clustet * BUG FIX FOR SMALL WINDOW: run against vecsim meiravg_svs_crash_fix with intel PUBLIC (no optimization) * return memory checkk * print proc mem * fix memory test flakyness * enable all flow * add svs size debug print * vecsim point to meiravg_protect_bg_indexing_info dix cluster wait to wait_for_background_indexing enable BUILD_INTEL_SVS_OPT * point vecsim to meiravg_protect_bg_indexing_info * adjust change_threadsfor coord take vecsim meiravg_protect_bg_indexing_info_fix * cluster skip change_threads and test_gc skip test_small_window_size until bug is fixed skip test_hybrid_query_with_text_vamana until bug is fixed * cleanup * enable test_create enable for cluster: test_rdb_load_trained_svs_vamana * fix spell * bumo vecsim RedisAI/VectorSimilarity#813 * split queries_sanity * less vectors in test_hybrid_query_with_text_vamana larger batch * disable temp * test_rdb_load_trained_svs_vamana: dim: 4-> 2 num docs: * 2 -> *1.1 data_type: all-> random test_svs_vamana_info dim: 16-> 2 num docs: * 2 -> *1.1 compression_type: all-> with EXTENDED_PYTESTS test_vamana_debug_info_vs_info diim: 4->2 test_memory_info: dim: 10->2 datatype-> random queries_sanity: generate outsize num_docs: * 2-> 1.1 query: num_docs-> 1 test_vamana_debug_info_vs_info: dim 4->2 test_memory_info dim: 10->2 data_type: random test_drop_index_memory dim: 4-> 2 test_gc: dim 128->? 28 * reduce to 300 * fix test_index_multi_value_json for coord remove env arg from test_rdb_load_trained_svs_vamana * wait_for_background_indexing print size in message * fix wait message * more time * increase timeout print all shards info * index_size->index_sizes * align to apply Ishwar fix on top of v0.0.10 in vecsim disable intel opt to run against svs public repo with the fix enable intel flow disable unit tests * remove the skip.... * test_index_multi_value_json increase CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE * use vecsim main * use BUILD_INTEL_SVS_OPT * return test_small_window_size skip * queries_sanity: CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE as number of docs wait_for_background_indexing: print on mac * print with force * prined is_trained arr * fix index_state print * fix test_drop_index_during_query to use svs.... be more verbose in change_threads increasetimeout * wf cleanups * test_drop_index_during_query: check query result wait_for_background_indexing: remove mac print
redisearch-backport-pull-request bot
pushed a commit
to RediSearch/RediSearch
that referenced
this pull request
Nov 5, 2025
* introdcue vecsim_utils and test_vecsim_svs move set_up_database_with_vectors and get_unique_vector from test_shard_k_ratio.py so it can be used by other test files add NO_COMPRESSION to test_svs_vamana_info_with_compression * apply trainingTriggerThreshold default value in vector index params only if quantBits == VecSimSvsQuant_NONE to align with vecsim logic that uses update_threshold for non-compressed indices VecSim_IsLeanVecCompressionType now also checks if isLVQSupported() * fix common and vecsim utils * fix typo * add test_empty_index * change_threads and test_drop_index * implment hybrid query fi test_index_multi_value_json to intialzie svs * fix test * gc test * TO REVERT: VECSIM VERSION! * bumo vecsim * test_hybrid_query_with_text_vamana: no compression test_small_window_size: wrap with try test_drop_index: decrease dim test_drop_index_during_query: skip cluster * skip gc test * revert skip * revert change (?) * revert back disable unit tesdsts * no specific * fix test_hybrid_query_with_text_vamana * revert vec generation * global seed 42 again fix query declaration, run only vecsim svs * return correct field name * 2 * block_size vecs * print vectors * upload vecs * skip ccoed test_small_window_size * fix path * skip coord * increase size * imp queries_sanity for coord fix test_insufficient_docs_per_shard CONSTRUCTION_WINDOW_SIZE = 20 * enable intel CI * no opt * fix comon * fix field name enable CI * enable intel * test_small_window_size :return on creash compare_debug_info_to_ft_info: fix to work, but queries_sanity: fix to use con, queries_sanity empty_index: ready for clustet * BUG FIX FOR SMALL WINDOW: run against vecsim meiravg_svs_crash_fix with intel PUBLIC (no optimization) * return memory checkk * print proc mem * fix memory test flakyness * enable all flow * add svs size debug print * vecsim point to meiravg_protect_bg_indexing_info dix cluster wait to wait_for_background_indexing enable BUILD_INTEL_SVS_OPT * point vecsim to meiravg_protect_bg_indexing_info * adjust change_threadsfor coord take vecsim meiravg_protect_bg_indexing_info_fix * cluster skip change_threads and test_gc skip test_small_window_size until bug is fixed skip test_hybrid_query_with_text_vamana until bug is fixed * cleanup * enable test_create enable for cluster: test_rdb_load_trained_svs_vamana * fix spell * bumo vecsim RedisAI/VectorSimilarity#813 * split queries_sanity * less vectors in test_hybrid_query_with_text_vamana larger batch * disable temp * test_rdb_load_trained_svs_vamana: dim: 4-> 2 num docs: * 2 -> *1.1 data_type: all-> random test_svs_vamana_info dim: 16-> 2 num docs: * 2 -> *1.1 compression_type: all-> with EXTENDED_PYTESTS test_vamana_debug_info_vs_info diim: 4->2 test_memory_info: dim: 10->2 datatype-> random queries_sanity: generate outsize num_docs: * 2-> 1.1 query: num_docs-> 1 test_vamana_debug_info_vs_info: dim 4->2 test_memory_info dim: 10->2 data_type: random test_drop_index_memory dim: 4-> 2 test_gc: dim 128->? 28 * reduce to 300 * fix test_index_multi_value_json for coord remove env arg from test_rdb_load_trained_svs_vamana * wait_for_background_indexing print size in message * fix wait message * more time * increase timeout print all shards info * index_size->index_sizes * align to apply Ishwar fix on top of v0.0.10 in vecsim disable intel opt to run against svs public repo with the fix enable intel flow disable unit tests * remove the skip.... * test_index_multi_value_json increase CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE * use vecsim main * use BUILD_INTEL_SVS_OPT * return test_small_window_size skip * queries_sanity: CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE as number of docs wait_for_background_indexing: print on mac * print with force * prined is_trained arr * fix index_state print * fix test_drop_index_during_query to use svs.... be more verbose in change_threads increasetimeout * wf cleanups * test_drop_index_during_query: check query result wait_for_background_indexing: remove mac print (cherry picked from commit 72d000f)
github-merge-queue bot
pushed a commit
to RediSearch/RediSearch
that referenced
this pull request
Nov 5, 2025
[MOD-10424] Flow tests for SVS-VAMANA (#6582) * introdcue vecsim_utils and test_vecsim_svs move set_up_database_with_vectors and get_unique_vector from test_shard_k_ratio.py so it can be used by other test files add NO_COMPRESSION to test_svs_vamana_info_with_compression * apply trainingTriggerThreshold default value in vector index params only if quantBits == VecSimSvsQuant_NONE to align with vecsim logic that uses update_threshold for non-compressed indices VecSim_IsLeanVecCompressionType now also checks if isLVQSupported() * fix common and vecsim utils * fix typo * add test_empty_index * change_threads and test_drop_index * implment hybrid query fi test_index_multi_value_json to intialzie svs * fix test * gc test * TO REVERT: VECSIM VERSION! * bumo vecsim * test_hybrid_query_with_text_vamana: no compression test_small_window_size: wrap with try test_drop_index: decrease dim test_drop_index_during_query: skip cluster * skip gc test * revert skip * revert change (?) * revert back disable unit tesdsts * no specific * fix test_hybrid_query_with_text_vamana * revert vec generation * global seed 42 again fix query declaration, run only vecsim svs * return correct field name * 2 * block_size vecs * print vectors * upload vecs * skip ccoed test_small_window_size * fix path * skip coord * increase size * imp queries_sanity for coord fix test_insufficient_docs_per_shard CONSTRUCTION_WINDOW_SIZE = 20 * enable intel CI * no opt * fix comon * fix field name enable CI * enable intel * test_small_window_size :return on creash compare_debug_info_to_ft_info: fix to work, but queries_sanity: fix to use con, queries_sanity empty_index: ready for clustet * BUG FIX FOR SMALL WINDOW: run against vecsim meiravg_svs_crash_fix with intel PUBLIC (no optimization) * return memory checkk * print proc mem * fix memory test flakyness * enable all flow * add svs size debug print * vecsim point to meiravg_protect_bg_indexing_info dix cluster wait to wait_for_background_indexing enable BUILD_INTEL_SVS_OPT * point vecsim to meiravg_protect_bg_indexing_info * adjust change_threadsfor coord take vecsim meiravg_protect_bg_indexing_info_fix * cluster skip change_threads and test_gc skip test_small_window_size until bug is fixed skip test_hybrid_query_with_text_vamana until bug is fixed * cleanup * enable test_create enable for cluster: test_rdb_load_trained_svs_vamana * fix spell * bumo vecsim RedisAI/VectorSimilarity#813 * split queries_sanity * less vectors in test_hybrid_query_with_text_vamana larger batch * disable temp * test_rdb_load_trained_svs_vamana: dim: 4-> 2 num docs: * 2 -> *1.1 data_type: all-> random test_svs_vamana_info dim: 16-> 2 num docs: * 2 -> *1.1 compression_type: all-> with EXTENDED_PYTESTS test_vamana_debug_info_vs_info diim: 4->2 test_memory_info: dim: 10->2 datatype-> random queries_sanity: generate outsize num_docs: * 2-> 1.1 query: num_docs-> 1 test_vamana_debug_info_vs_info: dim 4->2 test_memory_info dim: 10->2 data_type: random test_drop_index_memory dim: 4-> 2 test_gc: dim 128->? 28 * reduce to 300 * fix test_index_multi_value_json for coord remove env arg from test_rdb_load_trained_svs_vamana * wait_for_background_indexing print size in message * fix wait message * more time * increase timeout print all shards info * index_size->index_sizes * align to apply Ishwar fix on top of v0.0.10 in vecsim disable intel opt to run against svs public repo with the fix enable intel flow disable unit tests * remove the skip.... * test_index_multi_value_json increase CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE * use vecsim main * use BUILD_INTEL_SVS_OPT * return test_small_window_size skip * queries_sanity: CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE as number of docs wait_for_background_indexing: print on mac * print with force * prined is_trained arr * fix index_state print * fix test_drop_index_during_query to use svs.... be more verbose in change_threads increasetimeout * wf cleanups * test_drop_index_during_query: check query result wait_for_background_indexing: remove mac print (cherry picked from commit 72d000f) Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to RediSearch/RediSearch
that referenced
this pull request
Nov 5, 2025
[MOD-10424] Flow tests for SVS-VAMANA (#6582) * introdcue vecsim_utils and test_vecsim_svs move set_up_database_with_vectors and get_unique_vector from test_shard_k_ratio.py so it can be used by other test files add NO_COMPRESSION to test_svs_vamana_info_with_compression * apply trainingTriggerThreshold default value in vector index params only if quantBits == VecSimSvsQuant_NONE to align with vecsim logic that uses update_threshold for non-compressed indices VecSim_IsLeanVecCompressionType now also checks if isLVQSupported() * fix common and vecsim utils * fix typo * add test_empty_index * change_threads and test_drop_index * implment hybrid query fi test_index_multi_value_json to intialzie svs * fix test * gc test * TO REVERT: VECSIM VERSION! * bumo vecsim * test_hybrid_query_with_text_vamana: no compression test_small_window_size: wrap with try test_drop_index: decrease dim test_drop_index_during_query: skip cluster * skip gc test * revert skip * revert change (?) * revert back disable unit tesdsts * no specific * fix test_hybrid_query_with_text_vamana * revert vec generation * global seed 42 again fix query declaration, run only vecsim svs * return correct field name * 2 * block_size vecs * print vectors * upload vecs * skip ccoed test_small_window_size * fix path * skip coord * increase size * imp queries_sanity for coord fix test_insufficient_docs_per_shard CONSTRUCTION_WINDOW_SIZE = 20 * enable intel CI * no opt * fix comon * fix field name enable CI * enable intel * test_small_window_size :return on creash compare_debug_info_to_ft_info: fix to work, but queries_sanity: fix to use con, queries_sanity empty_index: ready for clustet * BUG FIX FOR SMALL WINDOW: run against vecsim meiravg_svs_crash_fix with intel PUBLIC (no optimization) * return memory checkk * print proc mem * fix memory test flakyness * enable all flow * add svs size debug print * vecsim point to meiravg_protect_bg_indexing_info dix cluster wait to wait_for_background_indexing enable BUILD_INTEL_SVS_OPT * point vecsim to meiravg_protect_bg_indexing_info * adjust change_threadsfor coord take vecsim meiravg_protect_bg_indexing_info_fix * cluster skip change_threads and test_gc skip test_small_window_size until bug is fixed skip test_hybrid_query_with_text_vamana until bug is fixed * cleanup * enable test_create enable for cluster: test_rdb_load_trained_svs_vamana * fix spell * bumo vecsim RedisAI/VectorSimilarity#813 * split queries_sanity * less vectors in test_hybrid_query_with_text_vamana larger batch * disable temp * test_rdb_load_trained_svs_vamana: dim: 4-> 2 num docs: * 2 -> *1.1 data_type: all-> random test_svs_vamana_info dim: 16-> 2 num docs: * 2 -> *1.1 compression_type: all-> with EXTENDED_PYTESTS test_vamana_debug_info_vs_info diim: 4->2 test_memory_info: dim: 10->2 datatype-> random queries_sanity: generate outsize num_docs: * 2-> 1.1 query: num_docs-> 1 test_vamana_debug_info_vs_info: dim 4->2 test_memory_info dim: 10->2 data_type: random test_drop_index_memory dim: 4-> 2 test_gc: dim 128->? 28 * reduce to 300 * fix test_index_multi_value_json for coord remove env arg from test_rdb_load_trained_svs_vamana * wait_for_background_indexing print size in message * fix wait message * more time * increase timeout print all shards info * index_size->index_sizes * align to apply Ishwar fix on top of v0.0.10 in vecsim disable intel opt to run against svs public repo with the fix enable intel flow disable unit tests * remove the skip.... * test_index_multi_value_json increase CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE * use vecsim main * use BUILD_INTEL_SVS_OPT * return test_small_window_size skip * queries_sanity: CONSTRUCTION_WINDOW_SIZE and SEARCH_WINDOW_SIZE as number of docs wait_for_background_indexing: print on mac * print with force * prined is_trained arr * fix index_state print * fix test_drop_index_during_query to use svs.... be more verbose in change_threads increasetimeout * wf cleanups * test_drop_index_during_query: check query result wait_for_background_indexing: remove mac print (cherry picked from commit 72d000f) Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #811 to safely read the value of updateJobMutex under the lock guard.