[MOD-12346] Remove main-thread graph repair from SVS delete operations #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiravgri
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
==========================================
+ Coverage 96.63% 96.66% +0.02%
==========================================
Files 126 126
Lines 7379 7374 -5
==========================================
- Hits 7131 7128 -3
+ Misses 248 246 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
reviewed
Nov 11, 2025
indexLabelCount -> only valid vectors
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alonre24
approved these changes
Nov 23, 2025
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-831-to-8.2 origin/8.2
cd .worktree/backport-831-to-8.2
git switch --create backport-831-to-8.2
git cherry-pick -x 11ea88d17345c007ae6f040311da356dc15bd621 |
meiravgri
added a commit
that referenced
this pull request
Nov 24, 2025
#831) * remove consolidate from delete * indexSize -> includes marked deleted indexLabelCount -> only valid vectors * fix flow tests * Revert "fix flow tests" This reverts commit 831c08c. * Revert "indexSize -> includes marked deleted" This reverts commit 82758c2. * TO REVERT: bump to main SVS * BUMP TO ib/buffer * SVS v0.0.11: take updated bunaries and SVS public * Reapply "indexSize -> includes marked deleted" This reverts commit 3ae28cd. * Reapply "fix flow tests" This reverts commit 45462d4. (cherry picked from commit 11ea88d)
This was referenced Nov 24, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
…rations (#831) (#841) * [MOD-12346] Remove main-thread graph repair from SVS delete operations (#831) * remove consolidate from delete * indexSize -> includes marked deleted indexLabelCount -> only valid vectors * fix flow tests * Revert "fix flow tests" This reverts commit 831c08c. * Revert "indexSize -> includes marked deleted" This reverts commit 82758c2. * TO REVERT: bump to main SVS * BUMP TO ib/buffer * SVS v0.0.11: take updated bunaries and SVS public * Reapply "indexSize -> includes marked deleted" This reverts commit 3ae28cd. * Reapply "fix flow tests" This reverts commit 45462d4. (cherry picked from commit 11ea88d) * remove test * remove test * merge meriavg_fix_fp16_svs * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 1:
Consolidation during
deleteVector()operations blocks the main thread significantly.Benchmarks show ~20 seconds to delete 500 vectors from a 1M vector index.
This PR removes automatic consolidation, leaving cleanup to the GC process.
Fix 2:
Align
indexSizeandindexLabelCountwith HNSW behaviour:IndexSize = indexLabelCount + num_marked_deletedindexLabelCountrepresents only valid vectors.Note: Unlike hnsw, svs doesn't perform in-place deletion, so this logic also applies to svs in a non-tiered index context.