Skip to content

ci: temporarily disable focal job in merge-queue and nightly flows#954

Merged
dor-forer merged 1 commit intomainfrom
dorer-disable-focal-temporarily
May 5, 2026
Merged

ci: temporarily disable focal job in merge-queue and nightly flows#954
dor-forer merged 1 commit intomainfrom
dorer-disable-focal-temporarily

Conversation

@dor-forer
Copy link
Copy Markdown
Collaborator

@dor-forer dor-forer commented May 5, 2026

Describe the changes in the pull request

Comment out the focal job (and its corresponding needs: entry) in both event-merge-to-queue.yml and event-nightly.yml, so the merge queue and nightly notifier are no longer blocked by Ubuntu 20.04 CI failures.

For the past several days, Canonical's PPA edge (ppa.launchpad.net / ppa.launchpadcontent.net, both resolving to 185.125.190.80) has been intermittently refusing connections, causing add-apt-repository ppa:ubuntu-toolchain-r/test to fail in .install/ubuntu_20.04.sh. We need that PPA because focal's stock GCC is 9, but the SVS code path requires C++20 features that need GCC ≥ 11 (see cmake/svs.cmake). The outage was verified from both the GitHub-hosted runner and a local network, confirming it is upstream and not workflow- or runner-related; no amount of apt retry/timeout/mirror-swap configuration in our workflow can route around it.

focal.yml itself is left untouched and remains manually-triggerable via workflow_dispatch, so we can keep iterating on a fix (likely a pre-built CI image with gcc-11 baked in to remove the per-run Launchpad dependency) without re-enabling it in any auto-flow. A TODO: comment marks the spot for re-enablement.

Which issues this PR fixes

  1. N/A — unblocks the merge queue from a transient upstream (Canonical) outage; no internal issue ID.

Main objects this PR modified

  1. .github/workflows/event-merge-to-queue.ymlfocal job and its entry in pr-validation.needs commented out.
  2. .github/workflows/event-nightly.ymlfocal job and its entry in notify-on-failure.needs commented out.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Low Risk
Low risk: workflow-only change that removes Ubuntu 20.04 (focal) from required job dependencies, which may reduce CI coverage but does not affect runtime code.

Overview
Temporarily comments out the Ubuntu 20.04 (focal) job in event-merge-to-queue.yml and event-nightly.yml, with a TODO note for re-enabling.

Updates the aggregate gating jobs (pr-validation and notify-on-failure) to drop focal from their needs, so merge-queue validation and nightly notifications no longer wait on focal results.

Reviewed by Cursor Bugbot for commit 005d600. Bugbot is set up for automated code reviews on this repo. Configure here.

Launchpad's PPA infrastructure (ppa.launchpad.net / ppa.launchpadcontent.net)
has been intermittently refusing connections for several days, breaking
focal's install of gcc-11 from ppa:ubuntu-toolchain-r/test which is
required because focal needs gcc-11 for the SVS code path's C++20 features.

Comment out the focal job in both event-merge-to-queue.yml and
event-nightly.yml (and the corresponding entries in their respective
needs: lists) so the merge queue and nightly notifier are not blocked by
this upstream outage. focal.yml itself is untouched and remains
manually-triggerable via workflow_dispatch.

To be reverted once a durable solution (likely a pre-built CI image with
gcc-11 baked in, removing the per-run Launchpad dependency) is in place.
@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented May 5, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@dor-forer dor-forer changed the title ci: temporarily disable focal job in merge-queue flow ci: temporarily disable focal job in merge-queue and nightly flows May 5, 2026
@dor-forer dor-forer marked this pull request as ready for review May 5, 2026 08:17
@dor-forer dor-forer requested a review from Copilot May 5, 2026 08:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily removes the Ubuntu 20.04 (“focal”) CI job from the merge-queue and nightly workflows so those automated flows aren’t blocked by upstream Launchpad PPA connectivity failures, while keeping focal.yml available for manual runs.

Changes:

  • Commented out the focal job in the merge-queue workflow.
  • Commented out the focal job in the nightly workflow.
  • Removed focal from the corresponding needs: lists so validation/notification jobs no longer wait on it.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/event-nightly.yml Disables focal in nightly and removes it from notify-on-failure.needs.
.github/workflows/event-merge-to-queue.yml Disables focal in merge-queue and removes it from pr-validation.needs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/event-nightly.yml
Comment thread .github/workflows/event-merge-to-queue.yml
Comment thread .github/workflows/event-merge-to-queue.yml
@dor-forer dor-forer added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit fe17589 May 5, 2026
38 of 44 checks passed
@dor-forer dor-forer deleted the dorer-disable-focal-temporarily branch May 5, 2026 09:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Backport failed for 0.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 0.6
git worktree add -d .worktree/backport-954-to-0.6 origin/0.6
cd .worktree/backport-954-to-0.6
git switch --create backport-954-to-0.6
git cherry-pick -x fe175897c1dff9e9f5adb41b030baa34993bcce9

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Backport failed for 0.7, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 0.7
git worktree add -d .worktree/backport-954-to-0.7 origin/0.7
cd .worktree/backport-954-to-0.7
git switch --create backport-954-to-0.7
git cherry-pick -x fe175897c1dff9e9f5adb41b030baa34993bcce9

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Backport failed for 0.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 0.8
git worktree add -d .worktree/backport-954-to-0.8 origin/0.8
cd .worktree/backport-954-to-0.8
git switch --create backport-954-to-0.8
git cherry-pick -x fe175897c1dff9e9f5adb41b030baa34993bcce9

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Git push to origin failed for 8.2 with exitcode 1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Git push to origin failed for 8.4 with exitcode 1

github-merge-queue Bot pushed a commit that referenced this pull request May 5, 2026
…ows (#954) (#957)

ci: temporarily disable focal job in merge-queue and nightly flows (#954)

Launchpad's PPA infrastructure (ppa.launchpad.net / ppa.launchpadcontent.net)
has been intermittently refusing connections for several days, breaking
focal's install of gcc-11 from ppa:ubuntu-toolchain-r/test which is
required because focal needs gcc-11 for the SVS code path's C++20 features.

Comment out the focal job in both event-merge-to-queue.yml and
event-nightly.yml (and the corresponding entries in their respective
needs: lists) so the merge queue and nightly notifier are not blocked by
this upstream outage. focal.yml itself is untouched and remains
manually-triggerable via workflow_dispatch.

To be reverted once a durable solution (likely a pre-built CI image with
gcc-11 baked in, removing the per-run Launchpad dependency) is in place.

(cherry picked from commit fe17589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants