Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
BenGoldberger
approved these changes
May 5, 2026
BenGoldberger
approved these changes
May 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 130 130
Lines 7749 7749
=======================================
Hits 7511 7511
Misses 238 238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Follow-up to #947 (which bumped
release-drafter/release-drafterfrom v6 to v7).In v7, authentication moved from the
GITHUB_TOKENenvironment variable to atokeninput (which defaults to${{ github.token }}). The existingenv: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}block is now silently ignored.The workflow currently still functions because v7 falls back to the default
github.token, but the explicit token configuration is dead config — which would become a real problem if a PAT were ever needed here instead of the default token. This PR moves the token to the documentedwith: token:input so the original intent is preserved.- uses: release-drafter/release-drafter@v7 with: # (Optional) specify config name to use, relative to .github/. Default: release-drafter.yml - config-name: release-drafter-config.yml - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + config-name: release-drafter-config.yml + token: ${{ secrets.GITHUB_TOKEN }}This fix will also be propagated to the open backport PRs (#960, #961, #962, #963, #964).
Which issues this PR fixes
Main objects this PR modified
.github/workflows/release-drafter.ymlMark if applicable
Note
Low Risk
Low risk workflow-only change that updates how the Release Drafter GitHub Action receives credentials; the main risk is misconfiguration causing release notes drafting to fail.
Overview
Updates the
release-drafterGitHub Actions workflow to pass authentication via the v7-supportedwith: tokeninput instead of theGITHUB_TOKENenvironment variable, keeping the explicit secret-based token configuration effective.Reviewed by Cursor Bugbot for commit 097d43f. Bugbot is set up for automated code reviews on this repo. Configure here.